Add confidential computing in aks module#423
Merged
lonegunmanb merged 2 commits intoAzure:mainfrom Aug 11, 2023
Merged
Conversation
lonegunmanb
requested changes
Aug 11, 2023
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @jiaweitao001, one comment.
| } | ||
|
|
||
| variable "confidential_computing" { | ||
| type = list(object({ |
Member
There was a problem hiding this comment.
According to the schema, could we set type to boolean for this variable?
Collaborator
Author
There was a problem hiding this comment.
Yes, we can simplify this type to a boolean, I was wondering there might be a possibility that more attributes will be added to this confidential_computing in the future, use a list would be more scalable?
Member
There was a problem hiding this comment.
Since the MaxItems of this list is 1 I think in that case, an object would be enough for us. WDYT?
Collaborator
Author
There was a problem hiding this comment.
Make sense. We can just use object instead of list.
lonegunmanb
approved these changes
Aug 11, 2023
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @jiaweitao001, LGTM!
skolobov
pushed a commit
to skolobov/terraform-azurerm-aks
that referenced
this pull request
Oct 29, 2023
* Add confidential computing in aks module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue number
#421
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!