-
Notifications
You must be signed in to change notification settings - Fork 513
add msi_auth_for_monitoring_enabled #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
a4f6084
4b96aa2
218e831
498e79a
f71d278
46b5902
7807414
7935982
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -445,7 +445,8 @@ resource "azurerm_kubernetes_cluster" "main" { | |
| for_each = var.log_analytics_workspace_enabled ? ["oms_agent"] : [] | ||
|
|
||
| content { | ||
| log_analytics_workspace_id = local.log_analytics_workspace.id | ||
| log_analytics_workspace_id = local.log_analytics_workspace.id | ||
| msi_auth_for_monitoring_enabled = var.msi_auth_for_monitoring_enabled | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is already present in provider version 3.47.0: No need to bump versions. All good. |
||
| } | ||
| } | ||
| dynamic "service_principal" { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -689,6 +689,12 @@ variable "maintenance_window_node_os" { | |
| EOT | ||
| } | ||
|
|
||
| variable "msi_auth_for_monitoring_enabled" { | ||
| type = bool | ||
| default = null | ||
| description = "(Optional) Is managed identity authentication for monitoring enabled? Defaults to `false`" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can remove "Defaults to
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @admincasper on line 695 at the end of the description string, can you remove: Thanks
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
@zioproto I think it needs to default to null. So I changed it to I think everything should be ok now then?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @admincasper line 694 is ok, the correct default is
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zioproto Done. Removed "Defaults to 'null'" in description. |
||
| } | ||
|
|
||
| variable "microsoft_defender_enabled" { | ||
| type = bool | ||
| default = false | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.