Skip to content

Add support for node_os_channel_upgrade#474

Merged
jiaweitao001 merged 4 commits intoAzure:mainfrom
lonegunmanb:node_os_channel_upgrade
Nov 14, 2023
Merged

Add support for node_os_channel_upgrade#474
jiaweitao001 merged 4 commits intoAzure:mainfrom
lonegunmanb:node_os_channel_upgrade

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

Describe your changes

Issue number

#419

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@zioproto
Copy link
Copy Markdown
Contributor

Should we add a precondition to implement the following ?

Screenshot 2023-11-13 at 08 44 40

@lonegunmanb
Copy link
Copy Markdown
Member Author

Should we add a precondition to implement the following ?

Screenshot 2023-11-13 at 08 44 40

Good idea! Will do!

Copy link
Copy Markdown
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🚢

@jiaweitao001 jiaweitao001 merged commit 2d48f28 into Azure:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants