feat(http_proxy_config): Add http_proxy_config#492
Merged
lonegunmanb merged 6 commits intoAzure:mainfrom Dec 22, 2023
Merged
Conversation
Related to: Azure#434 Signed-off-by: Iago Santos Pardo <iago.santos.pardo@adfinis.com>
Signed-off-by: Iago Santos Pardo <iago.santos.pardo@adfinis.com>
Signed-off-by: Iago Santos Pardo <iago.santos.pardo@adfinis.com>
3 tasks
zioproto
suggested changes
Dec 20, 2023
zioproto
approved these changes
Dec 21, 2023
This reverts commit d4777a0.
lonegunmanb
had a problem deploying
to
acctests
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
It's a forked pr based on #435, @isantospardo should take the credit. It has been a long time since #435 was opened and a lot of code have been changed, so I just fork #435's branch and rebase it with the latest
mainbranch.Adds a HTTP(S) proxy configuration within this module like described in the upstream Terraform Kubernetes Cluster resource.
This feature is currently not implemented yet and it would let us configure a HTTP(s) proxy for our AKS nodes with a customer CA as well.
You can have a look on a fork which enabled it, please see here.
Issue number
#434
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!