Add support for maintenance_window_auto_upgrade#505
Merged
lonegunmanb merged 2 commits intoAzure:mainfrom Feb 20, 2024
Merged
Conversation
docs: update README
skolobov
force-pushed
the
CR-4591-add-support-for-maintenance_window_auto_upgrade
branch
from
7c47516 to
04a8492
Compare
1 task
lonegunmanb
requested changes
Feb 18, 2024
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @skolobov for opening this pr! One review comment.
| - `day_of_month` - (Optional) The day of the month for the maintenance run. Required in combination with RelativeMonthly frequency. Value between 0 and 31 (inclusive). | ||
| - `day_of_week` - (Optional) The day of the week for the maintenance run. Options are `Monday`, `Tuesday`, `Wednesday`, `Thurday`, `Friday`, `Saturday` and `Sunday`. Required in combination with weekly frequency. | ||
| - `duration` - (Required) The duration of the window for maintenance to run in hours. | ||
| - `frequency` - (Required) Frequency of maintenance. Possible options are `Daily`, `Weekly`, `AbsoluteMonthly` and `RelativeMonthly`. |
Member
There was a problem hiding this comment.
According to the document, possible options are Weekly, AbsoluteMonthly and RelativeMonthly.
Contributor
Author
There was a problem hiding this comment.
Good catch, @lonegunmanb! That was my copy/paste mistake - sorry for that.
Fixed it now.
…the node OS maintenance
lonegunmanb
approved these changes
Feb 20, 2024
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @skolobov for the update, LGTM!
skolobov
deleted the
CR-4591-add-support-for-maintenance_window_auto_upgrade
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
azurerm_kubernetes_clusterresource in theazurermTerraform provider has variablemaintenance_window_auto_upgrade- please see official documentation hereThis adds support for maintenance window for automatic upgrades.
Issue number
#507
Checklist before requesting a review
CHANGELOG.mdfile