Skip to content

Add upgrade notice document#513

Merged
lonegunmanb merged 4 commits intomainfrom
upgrade-v8-memo
Mar 5, 2024
Merged

Add upgrade notice document#513
lonegunmanb merged 4 commits intomainfrom
upgrade-v8-memo

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

Describe your changes

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb
Copy link
Copy Markdown
Member Author

Hi @zioproto I've added an upgrade notice document for incoming v8, would you please give it a review? Thanks!

Copy link
Copy Markdown
Contributor

@zioproto zioproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Please check if the section about log analytics needs to be changed. Thanks

Comment thread NoticeOnUpgradeTov8.0.md
Comment thread NoticeOnUpgradeTov8.0.md
Comment thread NoticeOnUpgradeTov8.0.md
Comment thread NoticeOnUpgradeTov8.0.md Outdated

## Redesign variable for new created `azurerm_log_analytics_workspace`

1. The `cluster_log_analytics_workspace_name` variable has been replaced with a new `new_log_analytics_workspace` variable. This new variable is an object that allows for more granular configuration of the Log Analytics Workspace.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still under development ? Correct ? #515

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct, if we decide to not merge #515 then I'll remove this section.

@lonegunmanb lonegunmanb requested a review from zioproto February 26, 2024 02:08
@lonegunmanb
Copy link
Copy Markdown
Member Author

Thanks @zioproto for the code review, I've fixed all comments you've left but only one left, I'll decide how should we process this log analysis section once we're on the same page on #515 .

@lonegunmanb lonegunmanb merged commit 57c5c49 into main Mar 5, 2024
@lonegunmanb lonegunmanb deleted the upgrade-v8-memo branch December 2, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants