Update Microsoft.ContainerService managedClusters API version to 2024-02-01#552
Update Microsoft.ContainerService managedClusters API version to 2024-02-01#552lonegunmanb merged 3 commits intoAzure:mainfrom olofmattsson-inriver:patch/azapi_update_resource_version
Conversation
|
This is a valid issue
according to: the latest API version is correctly 2024-02-01 @lonegunmanb could we please merge this asap ? thanks |
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @olofmattsson-inriver for opening this pr to us! I have a question for the API version you assigned.
| count = can(var.http_proxy_config.no_proxy[0]) ? 1 : 0 | ||
|
|
||
| type = "Microsoft.ContainerService/managedClusters@2023-01-02-preview" | ||
| type = "Microsoft.ContainerService/managedClusters@2024-02-01-preview" |
There was a problem hiding this comment.
You've assigned two different API for two aks update resources, do we have any special reason for this?
There was a problem hiding this comment.
No other than my ignorance. My test passed so I didn't spot the typo. Updated the PR
olofmattsson-inriver
had a problem deploying
to
acctests
GitHub Actions
Failure
|
Hi @olofmattsson-inriver the e2e test failed, but I checked the error message, I believe we have fixed the issue which caused error in our latest main branch. Would you please rebase your branch with our latest main branch and try again? Thanks! |
|
Hi @lonegunmanb. I've rebased and hopefully, this will fix the issue. |
olofmattsson-inriver
had a problem deploying
to
acctests
GitHub Actions
Failure
olofmattsson-inriver
had a problem deploying
to
acctests
GitHub Actions
Failure
olofmattsson-inriver
had a problem deploying
to
acctests
GitHub Actions
Failure
olofmattsson-inriver
had a problem deploying
to
acctests
GitHub Actions
Failure
|
I'm going to merge this pr despite e2e test failure, since after a review I'm sure that the failure was caused by our fragile tests. |
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @olofmattsson-inriver , LGTM!
3 participants
Describe your changes
Support for Azure Kubernetes 2023-01-02-preview API is ending 20 June 2024. Update to the latest stable version.
Issue number