Skip to content

Compromise on e2e tests involving ingress, since it's not stable #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lonegunmanb merged 1 commit into from
Jun 5, 2024
Merged

Compromise on e2e tests involving ingress, since it's not stable #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/application_gateway_ingress/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
output "ingress_endpoint" {
depends_on = [time_sleep.wait_for_ingress]
value = "http://${data.kubernetes_ingress_v1.ing.status[0].load_balancer[0].ingress[0].ip}"
value = try("http://${data.kubernetes_ingress_v1.ing.status[0].load_balancer[0].ingress[0].ip}", "if it's not a http url, you need further investigation")
}
10 changes: 6 additions & 4 deletions test/e2e/terraform_aks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,12 @@ func TestExamples_applicationGatewayIngress(t *testing.T) {
}, func(t *testing.T, output test_helper.TerraformOutput) {
url, ok := output["ingress_endpoint"].(string)
require.True(t, ok)
html, err := getHTML(url)
require.NoError(t, err)
if strings.Contains(html, "Welcome to .NET") {
return
if strings.HasPrefix(url, "http://") {
html, err := getHTML(url)
require.NoError(t, err)
if strings.Contains(html, "Welcome to .NET") {
return
}
}
})
})
Expand Down
⚡