Add v4 sub-folder so this module could run with AzureRM provider both v3 and v4.#594
Add v4 sub-folder so this module could run with AzureRM provider both v3 and v4.#594lonegunmanb merged 22 commits intomainfrom
v4 sub-folder so this module could run with AzureRM provider both v3 and v4.#594Conversation
|
Is this one on the radar? I'm waiting for this module to be ready for V4 so that I can leverage the options V4 has to offer like |
|
Anything we can do to help move this along? We'd like to update our azurerm provider to 4.x |
|
The failed action clearly states the problem:
6 hours is GitHub's usage limit. I'd guess splitting up the test into smaller chunks should solve this. |
|
Hello all, if you have a urgent need to move to azurerm v4, This module is guaranteed to be V4 by the end of January 2025. For the current |
Thanks a lot @philippeckelintive for this comment. I'll try to solve this issue. |
There was a problem hiding this comment.
Copilot reviewed 64 out of 82 changed files in this pull request and generated 1 suggestion.
Files not reviewed (18)
- deprecated_variables.tf: Language not supported
- examples/application_gateway_ingress_v4/data.tf: Language not supported
- examples/application_gateway_ingress_v4/k8s_workload.tf: Language not supported
- examples/application_gateway_ingress_v4/main.tf: Language not supported
- examples/application_gateway_ingress_v4/main_override.tf: Language not supported
- examples/application_gateway_ingress_v4/outputs.tf: Language not supported
- examples/application_gateway_ingress_v4/providers.tf: Language not supported
- examples/application_gateway_ingress_v4/providers_override.tf: Language not supported
- examples/application_gateway_ingress_v4/variables.tf: Language not supported
- examples/multiple_node_pools/main.tf: Language not supported
- examples/multiple_node_pools/main_override.tf: Language not supported
- examples/multiple_node_pools_v4/main.tf: Language not supported
- examples/multiple_node_pools_v4/main_override.tf: Language not supported
- examples/multiple_node_pools_v4/outputs.tf: Language not supported
- examples/multiple_node_pools_v4/providers.tf: Language not supported
- examples/multiple_node_pools_v4/providers_override.tf: Language not supported
- examples/multiple_node_pools_v4/variables.tf: Language not supported
- examples/named_cluster/main.tf: Language not supported
Describe your changes
This pr added
v4sub-folder and referenced all.tffiles via symbolic link, and patch resources by adding Terraform override files, so the users who'd like to use AzureRMv4could do it by setting module'ssourcetoAzure/aks/azurerm//v4.Issue number
#000
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!