Implement node_network_profile for default node pool#598
Merged
lonegunmanb merged 1 commit intomainfrom Nov 15, 2024
Merged
Conversation
25ffd7a to
a2374e3
Compare
1 task
a2374e3 to
f7999cc
Compare
lonegunmanb
reviewed
Nov 11, 2024
Member
lonegunmanb
left a comment
There was a problem hiding this comment.
@zioproto I see allowed_host_ports and application_security_group_ids in node_network_profile block, don't we need to add them in this pr?
Contributor
Author
The goal of this PR was to bring feature parity between the current extra terraform-azurerm-aks/extra_node_pool.tf Lines 117 to 123 in dce8047 If I implement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implements default_network_profile for the default node pool
Issue number
#524
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!