Make the Azure Key Vault public because private Key Vault requires preview API#599
Merged
Make the Azure Key Vault public because private Key Vault requires preview API#599
Conversation
…eview API Running Microsoft Terraform module AKS end to end tests I get this new error message I have never seen before from the ARM API: https://github.com/Azure/terraform-azurerm-aks/actions/runs/11665268834/job/32477571013?pr=598#step:3:6605 HTTP 400 "Vnet integration should be enabled when KeyVault network access is Private." I believe this is the root cause: https://learn.microsoft.com/en-us/azure/aks/use-kms-etcd-encryption#prerequisites ( See yellow warning box) However Vnet Integration is still preview as far as I know. Terraform provider azurerm V4 will not support preview features. https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/4.0-upgrade-guide#aks-migration-to-stable-api
Contributor
Author
|
The end to end test is now failing on the upgrade step. It cannot pass the upgrade test because the current main branch cannot pass the end to end test. |
lonegunmanb
approved these changes
Nov 7, 2024
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
This pr LGTM though it failed the version upgrade test, because it's about to fix this issue in the last version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running Microsoft Terraform module AKS end to end tests I get this new error message I have never seen before from the ARM API:
https://github.com/Azure/terraform-azurerm-aks/actions/runs/11665268834/job/32477571013?pr=598#step:3:6605
HTTP 400 "Vnet integration should be enabled when KeyVault network access is Private."
I believe this is the root cause:
https://learn.microsoft.com/en-us/azure/aks/use-kms-etcd-encryption#prerequisites ( See yellow warning box)
However Vnet Integration is still preview as far as I know. Terraform provider azurerm V4 will not support preview features. https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/4.0-upgrade-guide#aks-migration-to-stable-api
This is a workaround to get the CI running again.
This PR needs to be reverted once AKS API Vnet Integration goes GA