Implement Data Collection Rule for Container Insights

[zioproto]

Describe your changes

Implement Data Collection Rule for Container Insights. This completes the work started in PR #446

Issue number

#607

Checklist before requesting a review

• The pr title can be used to describe what this pr did in CHANGELOG.md file
• I have executed pre-commit on my machine
• I have passed pr-check on my machine

[zioproto]

@lonegunmanb this PR was implemented looking at the documentation example available here:

https://github.com/microsoft/Docker-Provider/tree/ci_prod/scripts/onboarding/aks/onboarding-msi-terraform-syslog

Cc: @ganga1980 and @wanlonghenry in case they have review comments. Thanks

[lonegunmanb]

@zioproto We've got the following error:

TestExamplesForV4/application_gateway_ingress_v4 2024-12-20T16:01:45Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: Attempt to get attribute from null value
│ 
│   on ../../v4/log_analytics.tf line 86, in locals:
│   86:   dcr_location = coalesce(local.log_analytics_workspace.location, try(data.azurerm_log_analytics_workspace.main[0].location, null))
│     ├────────────────
│     │ local.log_analytics_workspace is null
│ 
│ This value is null, so it does not have any attributes.
╵}
    apply.go:34: 
        	Error Trace:	/src/test/vendor/github.com/gruntwork-io/terratest/modules/terraform/apply.go:34
        	            				/src/test/vendor/github.com/Azure/terraform-module-test-helper/e2etest.go:107
        	            				/src/test/vendor/github.com/Azure/terraform-module-test-helper/e2etest.go:87
        	            				/src/test/vendor/github.com/Azure/terraform-module-test-helper/e2etest.go:55
        	            				/src/test/e2e/terraform_aks_test.go:211
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; ╷
        	            	│ Error: Attempt to get attribute from null value
        	            	│ 
        	            	│   on ../../v4/log_analytics.tf line 86, in locals:
        	            	│   86:   dcr_location = coalesce(local.log_analytics_workspace.location, try(data.azurerm_log_analytics_workspace.main[0].location, null))
        	            	│     ├────────────────
        	            	│     │ local.log_analytics_workspace is null
        	            	│ 
        	            	│ This value is null, so it does not have any attributes.
        	            	╵}
        	Test:       	TestExamplesForV4/application_gateway_ingress_v4

Need further investigation.

[lonegunmanb]

Could we try coalesce(try(local.log_analytics_workspace.location, null), try(data.azurerm_log_analytics_workspace.main[0].location, null)) here?

[zioproto]

@lonegunmanb I managed to find the correct expression, the E2E tests are now passing. Please have a look. Thanks

[lonegunmanb]

Thanks @zioproto , some comments

[lonegunmanb]

Could we rename this new variable to monitor_data_collection_rule_data_sources_syslog_facilities?

[lonegunmanb]

Could we rename this new variable to monitor_data_collection_rule_data_sources_syslog_levels?

[lonegunmanb]

Could we rename this new variable to monitor_data_collection_rule_extensions_streams?

[lonegunmanb]

We could use HCL syntax here:

{
        dataCollectionSettings = {
          interval = var.data_collection_settings.data_collection_interval
          namespaceFilteringMode = var.data_collection_settings.namespace_filtering_mode_for_data_collection
          namespaces = var.data_collection_settings.namespaces_for_data_collection
          enableContainerLogV2 = var.data_collection_settings.container_log_v2_enabled
        }
      }

[lonegunmanb]

Would count = (local.create_analytics_workspace && var.oms_agent_enabled) ? 1 : 0 be better?

[lonegunmanb]

Would count = (local.create_analytics_workspace && var.oms_agent_enabled) ? 1 : 0 be better?

[lonegunmanb]

Thanks @zioproto, LGTM!