feat: add node_pool_name output for extra node pools (PR #401)#744
Merged
lonegunmanb merged 3 commits intomainfrom Apr 10, 2026
Merged
feat: add node_pool_name output for extra node pools (PR #401)#744lonegunmanb merged 3 commits intomainfrom
lonegunmanb merged 3 commits intomainfrom
Conversation
Adds a new output `node_pool_name` that exposes the names of non-default node pools created via `var.node_pools`. The original PR #401 referenced the old `azurerm_kubernetes_cluster_node_pool.node_pool` resource which was split in v7.0 into `node_pool_create_before_destroy` and `node_pool_create_after_destroy`. This commit uses `merge()` to combine both resources into a single output map. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ter example - Add delegation block for Microsoft.Network/applicationGateways to azurerm_subnet.appgw in application_gateway_ingress example to fix ApplicationGatewayNetworkIsolationRequiresSubnetDelegation error - Set oidc_issuer_enabled = true in named_cluster example to match Azure AKS API default behavior and fix idempotency drift Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add oidc_issuer_enabled = true to multiple_node_pools example to match Azure AKS API default behavior (same fix as named_cluster) - Add actions to appgw subnet delegation to match Azure API response for Microsoft.Network/applicationGateways delegation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lonegunmanb
force-pushed
the
release/add-node-pools-output
branch
from
1ea0127 to
c21cfe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the feature requested in #401 by @SubatomicHero / @fleetwoodstack — adding a
node_pool_nameoutput that exposes the names of non-default node pools created viavar.node_pools.Changes
outputs.tf: Addednode_pool_nameoutput usingmerge()to combine bothnode_pool_create_before_destroyandnode_pool_create_after_destroyresources (the originalnode_poolresource was split in v7.0).README.md: Auto-updated bymake pre-commit(terraform-docs regeneration).Background
PR #401 was opened ~3 years ago but became stale due to merge conflicts and an outdated resource reference (
azurerm_kubernetes_cluster_node_pool.node_poolno longer exists). This PR applies the same intent with the corrected resource references on a clean release branch frommain.Closes #401