Fix null value check for undrainable_node_behavior#761
Open
skooNI wants to merge 1 commit intoAzure:mainfrom
Open
Fix null value check for undrainable_node_behavior#761skooNI wants to merge 1 commit intoAzure:mainfrom
skooNI wants to merge 1 commit intoAzure:mainfrom
Conversation
PR Azure#733 introduced a precondition to check for the value of `undrainable_node_behavior` however it fails when the value is `null`. This happens because Terraform does not short-circuit evaluate `||` and calls `contains` with `null`, which results in an error. This switches that check to use a ternary operator to check for `null`, which will short-circuit before calling `contains`. Signed-off-by: Steven Koo <steven.koo@emerson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
PR #733 introduced a precondition to check for the value of
undrainable_node_behaviorhowever it fails when the value isnull. This happens because Terraform does not short-circuit evaluate||and callscontainswithnull, which results in an error.This switches that check to use a ternary operator to check for
null, which will short-circuit before callingcontains.Issue number
Closes #760
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!