Skip to content

new parameter: api_server_authorized_ip_ranges#93

Closed
madejusz wants to merge 1 commit intoAzure:masterfrom
madejusz:master
Closed

new parameter: api_server_authorized_ip_ranges#93
madejusz wants to merge 1 commit intoAzure:masterfrom
madejusz:master

Conversation

@madejusz
Copy link
Copy Markdown

Fixes #000

Changes proposed in the pull request:

@ghost
Copy link
Copy Markdown

ghost commented Mar 15, 2021

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown
Contributor

@yupwei68 yupwei68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🚀 Please add this feature into the test in test/fixture to integrate the test CI and add this feature in example in README.

@anatoliykv
Copy link
Copy Markdown

Give us this update, please! It's quite important. Thank you!

@yupwei68
Copy link
Copy Markdown
Contributor

Hi @anatoliykv Please add this feature into test/fixture to integrate this feature into CI/CD test (Please ensure it runs successfully in the test) and add this feature into example in README to show an example to our users on how to use?

@fplantinga-guida
Copy link
Copy Markdown

fplantinga-guida commented Jun 3, 2021

@anatoliykv @yupwei68 Any updates on this? It is quite important for us as well

Copy link
Copy Markdown

@nickvth nickvth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix merge conflicts and other discussions

@milanof-huma
Copy link
Copy Markdown

@madejusz Please fix the merge. This is long standing issue and it can help multiple developers by merging this. Many thanks 👍

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #241, THIS PR WILL BE UPDATED.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR WILL BE UPDATED.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR WILL BE UPDATED.

@github-actions
Copy link
Copy Markdown
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb
Copy link
Copy Markdown
Member

I'm closing this pr since we've implemented this feature in #220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants