Skip to content

Clean-up: moved current correction print statement inside PSATD solver condition#6721

Open
oshapoval wants to merge 2 commits intoBLAST-WarpX:developmentfrom
oshapoval:update_runtime_output_table
Open

Clean-up: moved current correction print statement inside PSATD solver condition#6721
oshapoval wants to merge 2 commits intoBLAST-WarpX:developmentfrom
oshapoval:update_runtime_output_table

Conversation

@oshapoval
Copy link
Copy Markdown
Contributor

This PR updates the runtime output table by moving the current correction print statement inside the PSATD solver condition. It can be merged as a quick fix, but we may want to consider how to reorganize or improve this output.

@EZoni
Copy link
Copy Markdown
Member

EZoni commented Mar 27, 2026

Thanks, @oshapoval.

Answering this,

It can be merged as a quick fix, but we may want to consider how to reorganize or improve this output.

I proposed a way to improve this in #6183, but it hasn't been received positively, so I left it there. See, in particular, #6183 (comment).

The rationale behind #6183 was indeed to make the backend (the code) more maintainable and the frontend (the printed output) more polished, which sounds similar to what you commented.

@RemiLehe RemiLehe self-assigned this Mar 31, 2026
@RemiLehe RemiLehe self-requested a review March 31, 2026 23:46
@oshapoval
Copy link
Copy Markdown
Contributor Author

Understood. I wasn’t aware of 6183. We can have another internal discussion about what to do long term. I’m fine with either merging it now or closing.

@EZoni
Copy link
Copy Markdown
Member

EZoni commented Apr 6, 2026

Understood. I wasn’t aware of 6183. We can have another internal discussion about what to do long term. I’m fine with either merging it now or closing.

I think we should review and merge this PR in the meantime, since it does fix a bug in the user-facing output. #6183 was more along the line of the long-term question you mentioned in the PR description - I just wanted to connect the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants