Clean-up: moved current correction print statement inside PSATD solver condition#6721
Clean-up: moved current correction print statement inside PSATD solver condition#6721oshapoval wants to merge 2 commits intoBLAST-WarpX:developmentfrom
Conversation
|
Thanks, @oshapoval. Answering this,
I proposed a way to improve this in #6183, but it hasn't been received positively, so I left it there. See, in particular, #6183 (comment). The rationale behind #6183 was indeed to make the backend (the code) more maintainable and the frontend (the printed output) more polished, which sounds similar to what you commented. |
|
Understood. I wasn’t aware of 6183. We can have another internal discussion about what to do long term. I’m fine with either merging it now or closing. |
I think we should review and merge this PR in the meantime, since it does fix a bug in the user-facing output. #6183 was more along the line of the long-term question you mentioned in the PR description - I just wanted to connect the two. |
This PR updates the runtime output table by moving the current correction print statement inside the PSATD solver condition. It can be merged as a quick fix, but we may want to consider how to reorganize or improve this output.