In AddPlasma, fix for radial_numpercell_power#6804
Open
dpgrote wants to merge 1 commit intoBLAST-WarpX:developmentfrom
Open
In AddPlasma, fix for radial_numpercell_power#6804dpgrote wants to merge 1 commit intoBLAST-WarpX:developmentfrom
dpgrote wants to merge 1 commit intoBLAST-WarpX:developmentfrom
Conversation
dpgrote
added
geometry: RZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
AddPlasmaandAddPlasmaFlux, when in a radial geometry, the radial variation of the particle weight can be adjusted by the input parameterradial_numpercell_power. The particle distribution and weights are adjusted accordingly. Though, when the minimum radius,rmin, is greater than zero, the weights of the particles was not correct. The weights did not account for the fact that the particles before the transformation are generated only in the rangermintormaxwhereas the existing formula assumed that particles were created in the range 0 tormax(before transformation). The result is that fewer particles are generated than the weight is accounting for. Multiplying the weights by the factorrmax/(rmax - rmin)accounts for this difference.This addresses the issue raised in #6798.