Skip to content

Relax pybind11 version requirement for package managers#6805

Open
EZoni wants to merge 1 commit intoBLAST-WarpX:developmentfrom
EZoni:dependencies_version_min
Open

Relax pybind11 version requirement for package managers#6805
EZoni wants to merge 1 commit intoBLAST-WarpX:developmentfrom
EZoni:dependencies_version_min

Conversation

@EZoni
Copy link
Copy Markdown
Member

@EZoni EZoni commented Apr 24, 2026

Overview

Fix the issue raised in BLAST-ImpactX/impactx#1419 (comment):

@EZoni I overlooked something here: You do not want to update the version in find_package higher than needed, because that way we cannot build with version 3.0.0, 3.0.1, 3.0.2, and 3.0.3 in package managers anymore - even if those versions are totally fine. (e.g., conda-forge is still to ship 3.0.4, stands at 3.0.3. Spack has very good version control, too). So in other words: keep this here on 3.0.0 and below just update the version we download to the latest.

Related PRs

Notes

Please select "Hide whitespace" to review the changes or use git diff -w.

@EZoni EZoni added bug Something isn't working install component: third party Changes in WarpX that reflect a change in a third-party library bug: affects latest release Bug also exists in latest release version automation Changes related to automation of tasks, tools, etc. labels Apr 24, 2026
@EZoni EZoni force-pushed the dependencies_version_min branch from 64f3721 to 0ac21cf Compare April 24, 2026 17:56
@EZoni EZoni changed the title Set pybind11 minimum version manually Relax pybind11 version requirement for package managers Apr 24, 2026
@EZoni EZoni requested a review from ax3l April 24, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Changes related to automation of tasks, tools, etc. bug: affects latest release Bug also exists in latest release version bug Something isn't working component: third party Changes in WarpX that reflect a change in a third-party library install

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant