Skillion roofs are 7.5 storeys tall if no levels or angle are set

[zuzak]

I have a building part thus:
https://beakerboy.github.io/OSMBuilding/?id=1426868383
https://www.openstreetmap.org/way/1426868384

building:colour=lightyellow
building:levels=2
building:part=yes
roof:colour=grey
roof:direction=10
roof:shape=skillion

This is rendering in OSMBuilding as having a height of 22.5 metres, which is the equivalent of 7.5 storeys.

It looks like if the roof:shape is skillion, roof:levels is not defined, and roof:angle is not defined, we default to 22.5.

OSMBuilding/src/buildingpart.js

Line 165 in bbeba91

(calculatedOptions.roof.shape === 'skillion' ? (calculatedOptions.roof.angle ? Math.cos(calculatedOptions.roof.angle / 360 * 2 * Math.PI) * shapeHeight : 22.5) : null);

Should this fall back instead to null so that we end up with a roof that is 1 storey tall if no more specific values are set?

[Beakerboy]

Thank you! This section of code is supposed to set the slope of the roof to 22.5°, but it obviously fails at that. Are you a programmer? If so, feel free to fix it, add a unit test, and submit a pull request. I’m not picky. That would probably be the fastest way to get it done.

[Beakerboy]

Fixed