Errors when opening some objects

[deevroman]

https://beakerboy.github.io/OSMBuilding/index.html?id=419266377
https://beakerboy.github.io/OSMBuilding/index.html?type=relation&id=13285666

17:19:30.428 Uncaught (in promise) TypeError: way.getElementsByTagName is not a function
    isClosed https://beakerboy.github.io/OSMBuilding/src/extras/BuildingShapeUtils.js:48
    combineWays https://beakerboy.github.io/OSMBuilding/src/extras/BuildingShapeUtils.js:67
    buildShape https://beakerboy.github.io/OSMBuilding/src/multibuildingpart.js:30
    BuildingPart https://beakerboy.github.io/OSMBuilding/src/buildingpart.js:81
    MultiBuildingPart https://beakerboy.github.io/OSMBuilding/src/multibuildingpart.js:8
    addParts https://beakerboy.github.io/OSMBuilding/src/building.js:180
    Building https://beakerboy.github.io/OSMBuilding/src/building.js:84
    create https://beakerboy.github.io/OSMBuilding/src/building.js:46
    init https://beakerboy.github.io/OSMBuilding/src/index.js:58
    <anonymous> https://beakerboy.github.io/OSMBuilding/src/index.js:198
BuildingShapeUtils.js:48:26

Firefox 138

[deevroman]

https://beakerboy.github.io/OSMBuilding/index.html?type=relation&id=14667933

17:24:01.557 THREE.Object3D.add: object not an instance of THREE.Object3D. undefined 6 three.core.js:13657:12
    add https://unpkg.com/three@0.176.0/build/three.core.js:13657
    init https://beakerboy.github.io/OSMBuilding/src/index.js:66
    (Async: promise callback)
    init https://beakerboy.github.io/OSMBuilding/src/index.js:58
    <anonymous> https://beakerboy.github.io/OSMBuilding/src/index.js:198

By the way, &errorBox only shows normal logs, not errors

[Beakerboy]

Thanks! You are correct about the errorbox. I do a lot of my coding using GitHub as my IDE using my cell phone. The standard JavaScript console is not available with my iPhone, so I use the errorbox as a way to see hose diagnostic messages.

[Beakerboy]

This first building is super complex. I’m guessing there is a building part that is a relation and a combination of two or more lines, and which together form a closed way. There must be a bug in this code. At a bare minimum, if the isClosed() function returns false, a message should be printed to the console. Or maybe I shouldn’t assume that. Can a linear wall or fence be included as a building part?

Off the top of my head, the “direction” of the ways could be mismatched and the code isn’t smart to know that they do extend one another. It’s probably an issue like that.

[Beakerboy]

@deevroman one thing to note is according to the simple building standard, the building outline is supposed to be tagged with a height that is equal to or taller than the tallest containing part. My renderer will (and does) complain about this for this object.

[deevroman]

My renderer will (and does) complain about this for this object.

I would say that the main problem now is that the interface does not display these errors. It is difficult to understand if the data is being downloaded or if an error has occurred.

[Beakerboy]

I just reversed the direction of a few of the ways and that resolved the first error. There are more, but at least I:

1. know that this causes a problem, so I can code for it.
2. can write a test for it to make sure it does not come back.

[Beakerboy]

#75

[Beakerboy]

I think I've resolved the issues, but the objects may just be too large. I'm not seeing errors, but the page is just not rendering anything.

[deevroman]

Yes, there are too many objects 😅

[Beakerboy]

Are all three of these overly complex? If so, I’ll close this out.

[deevroman]

No, just the first one