Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/building.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,22 @@ import {MultiBuildingPart} from './multibuildingpart.js';
* XML data from the API.
*/
class Building {
// Latitude and longitude that transitioned to (0, 0)
/**
* Latitude and longitude that transitions to (0, 0)
* @type {number[2]}
*/
home = [];

// the parts
/**
* The parts.
* @type {BuildingPart[]}
*/
parts = [];

// the BuildingPart of the outer building parimeter
/**
* The building part of the outer parimeter.
* @type {BuildingPart}
*/
outerElement;

// DOM Tree of all elements to render
Expand Down Expand Up @@ -139,7 +148,10 @@ class Building {
const mesh = [];
if (this.parts.length > 0) {
this.outerElement.options.building.visible = false;
mesh.push(...this.outerElement.render());
const outerMeshes = this.outerElement.render();
outerMeshes[0].visible = false;
outerMeshes[1].visible = false;
mesh.push(...outerMeshes);
for (let i = 0; i < this.parts.length; i++) {
mesh.push(...this.parts[i].render());
}
Expand Down
18 changes: 18 additions & 0 deletions test/building.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,24 @@ test('Create Nodelist', () => {
expect(errors.length).toBe(0);
});


test('Invisible Outer Building', () => {
const bldg = new Building('31361386', data);
bldg.parts = [bldg.outerElement];
const mesh = bldg.render();
//expect outer building and roof to not be visible
expect(mesh[0].visible).toBe(false);
expect(mesh[1].visible).toBe(false);
});

test('Visible Outer Building', () => {
const bldg = new Building('31361386', data);
const mesh = bldg.render();
//expect outer building and roof to be visible
expect(mesh[0].visible).toBe(true);
expect(mesh[1].visible).toBe(true);
});

window.printError = printError;

var errors = [];
Expand Down