Add osmApiUrl param for custom osm servers#77
Merged
Beakerboy merged 1 commit intoBeakerboy:mainfrom Apr 25, 2025
Merged
Conversation
deevroman
force-pushed
the
custom-osm-api
branch
from
a846e07 to
491dc30
Compare
Beakerboy
approved these changes
Apr 25, 2025
Owner
Beakerboy
left a comment
Beakerboy
left a comment
There was a problem hiding this comment.
Looks great! I like the general improvements as well. I’m happy to take any pull request. Let me know if you know of a test we can add to jest for any of this stuff. I would like to add more tests to avoid breaking things as improvements are checked it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I wanted to do this for testing in the OSM sandbox https://master.apis.dev.openstreetmap.org/
But then I thought this might be one of the few 3D renders for OpenHistoricalMap and OpenGeofiction:
URL examples:
https://deevroman.github.io/OSMBuilding/?id=2826540&osmApiUrl=https://api.openhistoricalmap.org/api/0.6&type=relation
https://deevroman.github.io/OSMBuilding/?id=2851167&osmApiUrl=https://api.openhistoricalmap.org/api/0.6&type=relation
https://deevroman.github.io/OSMBuilding/?id=461819&osmApiUrl=https://opengeofiction.net/api/0.6&type=relation
https://deevroman.github.io/OSMBuilding/?id=384152&osmApiUrl=https://opengeofiction.net/api/0.6&type=relation
p.s. by the way I rewrote the code to use URLSearchParam instead of splitting the search string