Conversation
LiorF-BDBQ
reviewed
Feb 22, 2024
Comment on lines
+56
to
+58
| cat <<'EOF' >>/etc/elasticsearch/elasticsearch.yml | ||
| xpack.security.http.ssl.enabled: false | ||
| EOF |
Contributor
There was a problem hiding this comment.
Not sure this makes sense, I think we should configure it.
Contributor
Author
There was a problem hiding this comment.
I'll open a separate issue for this, but I understand this is not the focus of the current task - @synhershko
Either way in 8.x the flag must be either false or true.
# Conflicts: # terraform-gcp/main.tf
…dpoint ports, adding packer manifest, adding debug bootstrap mode, fixing redundant provider, adding certs renewal
# Conflicts: # .gitignore # assets/scripts/bootstrap.sh # assets/scripts/common/config-clients.sh # assets/scripts/common/config-cluster.sh # assets/scripts/common/config-es.sh # assets/scripts/gcp/autoattach-disk.sh # packer/README.md # packer/elasticsearch8-node.packer.json # packer/kibana8-node.packer.json # templates/aws_user_data.sh # templates/gcp_user_data.sh # terraform-aws/main.tf # terraform-aws/variables.tf # terraform-aws/vpc.tf # terraform-gcp/main.tf # terraform-gcp/variables.tf
# Conflicts: # templates/gcp_user_data.sh
LiorF-BDBQ
reviewed
Jun 10, 2024
Comment on lines
+1
to
+6
| # This file is maintained automatically by "terraform init". | ||
| # Manual edits may be lost in future updates. | ||
|
|
||
| provider "registry.terraform.io/hashicorp/aws" { | ||
| version = "5.37.0" | ||
| hashes = [ |
Contributor
There was a problem hiding this comment.
Do we need to keep this file? Lets add a required_providers block with all providers we use here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've checked out the current master branch to elasticsearch-7.x .
In this PR:
known issues:
FYI @LiorF-BDBQ @synhershko