Refactoring specialisations in binary_data_converter.hpp file#183
Open
riyasingh1004 wants to merge 1 commit intoBoostGSoC19:developfrom
riyasingh1004:refractoring_sp
Open
Refactoring specialisations in binary_data_converter.hpp file#183riyasingh1004 wants to merge 1 commit intoBoostGSoC19:developfrom riyasingh1004:refractoring_sp
riyasingh1004 wants to merge 1 commit intoBoostGSoC19:developfrom
riyasingh1004:refractoring_sp
Conversation
Member
|
@riyasingh1004 can you please rebase your branch so we can get our CI running. |
Author
|
@lpranam I have rebased my branch with the updated version of develop branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A quick look at the binary_data_converter reveals massive chunk of specializations used for parsing different variants of binary data. This can be reduced by using boost hana present in C++ 14 and make the code easy for maintenance purposes.
Tasklist