Skip to content

Risoluzione revisione#33

Closed
monen17 wants to merge 13 commits into
Borruso:18.0-add-preview_xmlfrom
monen17:18.0-imp-l10n_it_edi_extension-review
Closed

Risoluzione revisione#33
monen17 wants to merge 13 commits into
Borruso:18.0-add-preview_xmlfrom
monen17:18.0-imp-l10n_it_edi_extension-review

Conversation

@monen17

@monen17 monen17 commented Jul 18, 2025

Copy link
Copy Markdown

La revisione è OCA#4411 (review).

@Borruso Borruso force-pushed the 18.0-add-preview_xml branch 3 times, most recently from 4ff919b to ead2be7 Compare July 18, 2025 15:35
):
msg = self.env._("The fiscal code must have 16 characters.")
raise ValidationError(msg)
elif partner.company_type == "person":

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/odoo/odoo/blob/18.0/addons/l10n_it_edi/models/res_partner.py#L155-L159
controllare questa già c'è la validazione per questo probabilmente l'ho salatata

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ho tolto il controllo con isvalid

@monen17 monen17 force-pushed the 18.0-imp-l10n_it_edi_extension-review branch 4 times, most recently from 1355fad to ded868f Compare July 19, 2025 09:19
@monen17 monen17 closed this Jul 19, 2025
@monen17 monen17 force-pushed the 18.0-imp-l10n_it_edi_extension-review branch from ded868f to 45cdc78 Compare July 19, 2025 09:22
@monen17 monen17 reopened this Jul 19, 2025
@monen17 monen17 force-pushed the 18.0-imp-l10n_it_edi_extension-review branch 2 times, most recently from f51fc56 to 6f67299 Compare July 19, 2025 11:06
@monen17 monen17 marked this pull request as ready for review July 19, 2025 11:11
@Borruso Borruso force-pushed the 18.0-add-preview_xml branch 10 times, most recently from d08a71d to 8535d1f Compare July 25, 2025 10:18
@monen17 monen17 force-pushed the 18.0-imp-l10n_it_edi_extension-review branch from 6f67299 to 8f4053c Compare July 25, 2025 14:06
@monen17 monen17 marked this pull request as draft July 25, 2025 14:12
@monen17 monen17 marked this pull request as ready for review July 25, 2025 16:22
@monen17

monen17 commented Jul 28, 2025

Copy link
Copy Markdown
Author

Inclusa in OCA#4858.

@monen17 monen17 closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants