Skip to content

Refactor SKAN related code and BranchOpenRequest Class #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NidhiDixit09 merged 20 commits into from
Feb 23, 2026
Merged

Refactor SKAN related code and BranchOpenRequest Class #1570

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
321de8a
Refactoring BranchOpenRequest Class
NidhiDixit09 Feb 14, 2026
da13757
Removed swift version of Configuration Controller.
NidhiDixit09 Feb 16, 2026
f1082f6
Updated unit test to use objc version
NidhiDixit09 Feb 16, 2026
ddcbb1c
Fixed ODM test.
NidhiDixit09 Feb 16, 2026
e0441e4
Delete BNCAppleReceiptTests.m
NidhiDixit09 Feb 16, 2026
2fe94e5
Test commit
NidhiDixit09 Feb 16, 2026
8441152
Test commit 2
NidhiDixit09 Feb 16, 2026
ab69463
Test commit 3
NidhiDixit09 Feb 16, 2026
562424d
Removed Private path prefix from header include.
NidhiDixit09 Feb 16, 2026
dcad908
Test commit 3
NidhiDixit09 Feb 16, 2026
39d9751
SKAN logic is moved in BNCSKAdNetwork
NidhiDixit09 Feb 16, 2026
3af64f8
Refactoring BranchOpenRequest Class
NidhiDixit09 Feb 14, 2026
0ed9036
SKAN logic is moved in BNCSKAdNetwork
NidhiDixit09 Feb 16, 2026
b512e88
Merge branch 'ndixit/EMT-3068' of https://github.com/BranchMetrics/io…
NidhiDixit09 Feb 16, 2026
b4ef55e
Test commit
NidhiDixit09 Feb 16, 2026
3d620bb
Fixed handling of mis-parsed identity
NidhiDixit09 Feb 16, 2026
e57b69e
Fixed early return issue in func randomizedDeviceTokenFromResponseData.
NidhiDixit09 Feb 17, 2026
2e3fba2
Removed Auto Initialization (#1571)
NidhiDixit09 Feb 20, 2026
d17ae5a
PR Review fixes.
NidhiDixit09 Feb 23, 2026
03873ba
Merge branch '4.0.0-alpha.0' into ndixit/EMT-3068
NidhiDixit09 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,10 @@
E7AC747E2DB0714B002D8C40 /* libc++.tbd in Frameworks */ = {isa = PBXBuildFile; fileRef = E7AC747D2DB07145002D8C40 /* libc++.tbd */; };
E7AE4A092DFB2C4400696805 /* BranchConfigurationControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = E7AE4A082DFB2C4400696805 /* BranchConfigurationControllerTests.m */; };
E7CA74B22E1B4890002EFB40 /* BranchConstants.h in Headers */ = {isa = PBXBuildFile; fileRef = E7CA74B12E1B4890002EFB40 /* BranchConstants.h */; };
E7CA74B42E1B4944002EFB40 /* ConfigurationController.swift in Sources */ = {isa = PBXBuildFile; fileRef = E7CA74B32E1B4944002EFB40 /* ConfigurationController.swift */; };
E7E28ECA2DD2424C00F75D0D /* BNCInAppBrowser.m in Sources */ = {isa = PBXBuildFile; fileRef = E7E28EC82DD2424C00F75D0D /* BNCInAppBrowser.m */; };
F1CF14111F4CC79F00BB2694 /* CoreSpotlight.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 67F270881BA9FCFF002546A7 /* CoreSpotlight.framework */; settings = {ATTRIBUTES = (Required, ); }; };
AA00000003000000000000B1 /* BranchConfigurationController.h in Headers */ = {isa = PBXBuildFile; fileRef = AA00000003000000000000A1 /* BranchConfigurationController.h */; };
AA00000004000000000000B1 /* BranchConfigurationController.m in Sources */ = {isa = PBXBuildFile; fileRef = AA00000004000000000000A1 /* BranchConfigurationController.m */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand Down Expand Up @@ -381,7 +382,7 @@
5F644B3B2B7AA810000DCD78 /* BNCNetworkInterface.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BNCNetworkInterface.m; sourceTree = "<group>"; };
5F644B3C2B7AA810000DCD78 /* BNCPreferenceHelper.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BNCPreferenceHelper.m; sourceTree = "<group>"; };
5F644B3D2B7AA810000DCD78 /* BNCConfig.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BNCConfig.m; sourceTree = "<group>"; };
5F644B3E2B7AA810000DCD78 /* BranchConstants.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = BranchConstants.m; path = ../BranchSDK_ObjC/BranchConstants.m; sourceTree = "<group>"; };
5F644B3E2B7AA810000DCD78 /* BranchConstants.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BranchConstants.m; sourceTree = "<group>"; };
5F644B3F2B7AA810000DCD78 /* BranchContentDiscoveryManifest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BranchContentDiscoveryManifest.m; sourceTree = "<group>"; };
5F644B402B7AA810000DCD78 /* BranchSpotlightUrlRequest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BranchSpotlightUrlRequest.m; sourceTree = "<group>"; };
5F644B422B7AA810000DCD78 /* BranchContentDiscoverer.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = BranchContentDiscoverer.m; sourceTree = "<group>"; };
Expand Down Expand Up @@ -572,9 +573,10 @@
E7AC74782DB06D47002D8C40 /* NSError+Branch.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "NSError+Branch.h"; sourceTree = "<group>"; };
E7AC747D2DB07145002D8C40 /* libc++.tbd */ = {isa = PBXFileReference; lastKnownFileType = "sourcecode.text-based-dylib-definition"; name = "libc++.tbd"; path = "Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.2.sdk/usr/lib/libc++.tbd"; sourceTree = DEVELOPER_DIR; };
E7AE4A082DFB2C4400696805 /* BranchConfigurationControllerTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = BranchConfigurationControllerTests.m; sourceTree = "<group>"; };
E7CA74B12E1B4890002EFB40 /* BranchConstants.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = BranchConstants.h; path = ../Sources/BranchSDK_ObjC/Public/BranchConstants.h; sourceTree = SOURCE_ROOT; };
E7CA74B32E1B4944002EFB40 /* ConfigurationController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; name = ConfigurationController.swift; path = ../Sources/BranchSDK_Swift/ConfigurationController.swift; sourceTree = SOURCE_ROOT; };
E7CA74B12E1B4890002EFB40 /* BranchConstants.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BranchConstants.h; sourceTree = "<group>"; };
E7E28EC82DD2424C00F75D0D /* BNCInAppBrowser.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = BNCInAppBrowser.m; sourceTree = "<group>"; };
AA00000003000000000000A1 /* BranchConfigurationController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BranchConfigurationController.h; sourceTree = "<group>"; };
AA00000004000000000000A1 /* BranchConfigurationController.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = BranchConfigurationController.m; sourceTree = "<group>"; };
F1D4F9AC1F323F01002D13FF /* Branch-TestBed-UITests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "Branch-TestBed-UITests.xctest"; sourceTree = BUILT_PRODUCTS_DIR; };
/* End PBXFileReference section */

Expand Down Expand Up @@ -724,7 +726,6 @@
5F644B252B7AA810000DCD78 /* BranchSDK */ = {
isa = PBXGroup;
children = (
E7CA74B32E1B4944002EFB40 /* ConfigurationController.swift */,
E563942F2CC7AC9500E18E65 /* BranchFileLogger.m */,
5F644BB02B7AA811000DCD78 /* BNCAppGroupsData.m */,
5F644B2B2B7AA810000DCD78 /* BNCApplication.m */,
Expand Down Expand Up @@ -797,6 +798,7 @@
5F644B2D2B7AA810000DCD78 /* NSMutableDictionary+Branch.m */,
5F644B362B7AA810000DCD78 /* NSString+Branch.m */,
5F644BAF2B7AA811000DCD78 /* UIViewController+Branch.m */,
AA00000004000000000000A1 /* BranchConfigurationController.m */,
5F644B6E2B7AA810000DCD78 /* Private */,
5F644B522B7AA810000DCD78 /* Public */,
);
Expand Down Expand Up @@ -890,6 +892,7 @@
E51F64292CF46899000858D2 /* BranchFileLogger.h */,
5F644B752B7AA810000DCD78 /* UIViewController+Branch.h */,
E7AC74782DB06D47002D8C40 /* NSError+Branch.h */,
AA00000003000000000000A1 /* BranchConfigurationController.h */,
);
path = Private;
sourceTree = "<group>";
Expand Down Expand Up @@ -1092,6 +1095,7 @@
5F644C0F2B7AA811000DCD78 /* BranchOpenRequest.h in Headers */,
5F644C2C2B7AA811000DCD78 /* BNCRequestFactory.h in Headers */,
5F644C142B7AA811000DCD78 /* BNCDeviceSystem.h in Headers */,
AA00000003000000000000B1 /* BranchConfigurationController.h in Headers */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -1366,7 +1370,6 @@
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
E7CA74B42E1B4944002EFB40 /* ConfigurationController.swift in Sources */,
5F644BB92B7AA811000DCD78 /* NSError+Branch.m in Sources */,
5F644C482B7AA811000DCD78 /* BNCCallbackMap.m in Sources */,
5F644BBE2B7AA811000DCD78 /* BNCApplication.m in Sources */,
Expand Down Expand Up @@ -1438,6 +1441,7 @@
5F644C3B2B7AA811000DCD78 /* BNCInitSessionResponse.m in Sources */,
5F644BCF2B7AA811000DCD78 /* BNCPreferenceHelper.m in Sources */,
5F644C372B7AA811000DCD78 /* BranchContentPathProperties.m in Sources */,
AA00000004000000000000B1 /* BranchConfigurationController.m in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
6 changes: 2 additions & 4 deletions BranchSDK.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,10 @@ Use the Branch SDK (branch.io) to create and power the links that point back to
s.ios.deployment_target = '12.0'
s.tvos.deployment_target = '12.0'

s.swift_versions = ['5.0', '5.1', '5.2', '5.3', '5.4', '5.5', '5.6', '5.7', '5.8', '5.9', '6.0']

s.resource_bundles = { 'BranchSDK' => 'Sources/Resources/*.xcprivacy' }
s.ios.source_files = "Sources/BranchSDK/**/*.{h,m}", "Sources/BranchSDK_Swift/**/*.swift", "Sources/BranchSDK_ObjC/**/*.{h,m}"
s.ios.source_files = "Sources/BranchSDK/**/*.{h,m}"

s.tvos.source_files = "Sources/BranchSDK/**/*.{h,m}", "Sources/BranchSDK_Swift/**/*.swift", "Sources/BranchSDK_ObjC/**/*.{h,m}"
s.tvos.source_files = "Sources/BranchSDK/**/*.{h,m}"
s.tvos.exclude_files = "Sources/BranchSDK/**/BNCContentDiscoveryManager.{h,m}",
"Sources/BranchSDK/**/BNCUserAgentCollector.{h,m}",
"Sources/BranchSDK/**/BNCSpotlightService.{h,m}",
Expand Down
Loading
⚡