Fixed tests to use new API to disable auto init. by NidhiDixit09 · Pull Request #1580 · BranchMetrics/ios-branch-deep-linking-attribution

NidhiDixit09 · 2026-02-24T02:21:02Z

Reference

Summary

SDK Binary Integration tests were using API - setConsumerProtectionAttributionLevel along with initSession. Because of autoinitialization in setConsumerProtectionAttributionLevel initsession was losing deep link data.
This PR includes fix for above issue - it uses new API - - (void)setConsumerProtectionAttributionLevel:(BranchAttributionLevel)level resetSession:(BOOL)resetSession; - to avoid auto initialization.

Type Of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Testing Instructions

cc @BranchMetrics/saas-sdk-devs for visibility.

matterai-app · 2026-02-24T02:21:20Z

Summary By MatterAI

🔄 What Changed

Updated integration tests for iOS and tvOS to utilize the new setConsumerProtectionAttributionLevel(_:resetSession:) API with resetSession: false. This prevents unintended SDK auto-initialization that was causing deep link data loss. Added verbose logging and waitForExpectations to synchronize asynchronous session initialization before state assertions.

🔍 Impact of the Change

Fixes a critical issue where deep link data was lost during attribution level transitions. By using the non-resetting API, tests now accurately reflect privacy configuration scenarios without disrupting the session lifecycle, ensuring reliable SDK compliance verification.

📁 Total Files Changed

Click to Expand

File	ChangeLog
API Update `iOSReleaseTestTests.swift`	Switched to non-resetting attribution API and added verbose logging for iOS.
API Update `tvOSReleaseTestTests.swift`	Mirrored iOS changes for tvOS to ensure cross-platform test parity.

🧪 Test Added/Recommended

Added

testInitSessionAndSetCPPLevel: Updated to verify attribution levels persist correctly without triggering a session reset.
Branch.enableLogging: Added verbose logging callback to capture SDK internal state during test execution.

🔒 Security Vulnerabilities

No security vulnerabilities detected. The PR correctly focuses on privacy API implementation and test synchronization. 🛡️

⏳ Estimated code review effort

LOW (~8 minutes)

Tip

Quality Recommendations

Reduce the 90-second timeout to 30 seconds to optimize CI pipeline duration.
Use XCTContext.runActivity to organize verbose logs within the test report for better readability.
Consider wrapping verbose logging in a conditional flag to avoid console noise in standard local runs.

♫ Tanka Poem

Deep links lost in time,
Auto-init caused the crime,
Flags set false today,
Data flows the proper way,
Tests now in their prime. 🧪✨

Sequence Diagram

sequenceDiagram
    participant T as Integration Test
    participant B as Branch SDK
    participant P as BNCPreferenceHelper
    
    T->>B: enableLogging(at: .verbose)
    T->>B: setConsumerProtectionAttributionLevel(.none)
    T->>B: setConsumerProtectionAttributionLevel(.full, resetSession: false)
    T->>B: initSession()
    B-->>T: callback(params, error)
    Note over T: waitForExpectations(timeout: 90)
    T->>P: attributionLevel
    P-->>T: currentLevel
    T->>T: XCTAssertEqual(currentLevel, .none)

matterai-app · 2026-02-24T02:23:09Z

✅ Reviewed the changes: The PR looks good overall. The tests are updated to use the new API to disable auto-initialization and verify Consumer Protection Attribution (CPP) levels.

matterai-app · 2026-02-24T02:40:57Z

✅ Reviewed the changes: The PR description mentions using a new API to disable auto-initialization, but the code changes only add a waitForExpectations timeout and do not actually implement the new API call.

matterai-app · 2026-02-24T02:51:03Z

✅ Reviewed the changes: The changes correctly implement the new setConsumerProtectionAttributionLevel:resetSession: API to prevent auto-initialization during the test setup. The test flow properly validates the fix described in the PR.

matterai-app

🧪 PR Review is completed: The PR correctly introduces the new API to prevent auto-initialization, but there are instances where the old API is still being called, which might inadvertently trigger the issue being fixed.

matterai-app · 2026-02-24T02:55:52Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: The PR description states that the old setConsumerProtectionAttributionLevel API causes auto-initialization and the fix is to use the new API with the resetSession parameter. However, this line still uses the old API, which might trigger the unwanted auto-initialization before the next line executes.

Fix: Use the new API with resetSession: false for setting the level to .none as well, to ensure auto-initialization is completely avoided.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

matterai-app · 2026-02-24T02:55:52Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: Similar to the iOS test, this line still uses the old setConsumerProtectionAttributionLevel API which the PR aims to replace to prevent auto-initialization.

Fix: Use the new API with resetSession: false for setting the level to .none to maintain consistency and prevent unintended side effects.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

matterai-app

🧪 PR Review is completed: The PR still contains calls to the old setConsumerProtectionAttributionLevel API which can trigger the unwanted auto-initialization.

matterai-app · 2026-02-24T03:04:20Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: The PR description states that the old setConsumerProtectionAttributionLevel API causes auto-initialization and the fix is to use the new API with the resetSession parameter. However, this line still uses the old API, which might trigger the unwanted auto-initialization before the next line executes.

Fix: Use the new API with resetSession: false for setting the level to .none as well, to ensure auto-initialization is completely avoided.

Impact: Prevents unintended auto-initialization and deep link data loss during the test setup.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

matterai-app · 2026-02-24T03:04:21Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: Similar to the iOS test, this line still uses the old setConsumerProtectionAttributionLevel API which the PR aims to replace to prevent auto-initialization.

Fix: Use the new API with resetSession: false for setting the level to .none to maintain consistency and prevent unintended side effects.

Impact: Prevents unintended auto-initialization and deep link data loss during the test setup.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

matterai-app

🧪 PR Review is completed: The PR correctly introduces the new API to prevent auto-initialization, but there are still instances where the old API is being called, which defeats the purpose of the fix.

matterai-app · 2026-02-24T03:06:28Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: The PR description states that the old setConsumerProtectionAttributionLevel API causes auto-initialization and the fix is to use the new API with the resetSession parameter. However, this line still uses the old API, which might trigger the unwanted auto-initialization before the next line executes.

Fix: Use the new API with resetSession: false for setting the level to .none as well, to ensure auto-initialization is completely avoided.

Impact: Prevents unintended auto-initialization and deep link data loss during the test setup.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

matterai-app · 2026-02-24T03:06:28Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: Similar to the iOS test, this line still uses the old setConsumerProtectionAttributionLevel API which the PR aims to replace to prevent auto-initialization.

Fix: Use the new API with resetSession: false for setting the level to .none to maintain consistency and prevent unintended side effects.

Impact: Prevents unintended auto-initialization and deep link data loss during the test setup.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

matterai-app

🧪 PR Review is completed: The PR partially addresses the auto-initialization issue by using the new API on line 56, but line 55 still uses the old API which can trigger the unwanted auto-initialization.

matterai-app · 2026-02-24T03:08:53Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: The PR description states that the old setConsumerProtectionAttributionLevel API causes auto-initialization and the fix is to use the new API with the resetSession parameter. However, this line still uses the old API, which might trigger the unwanted auto-initialization before the next line executes.

Fix: Use the new API with resetSession: false for setting the level to .none as well, to ensure auto-initialization is completely avoided.

Impact: Prevents unintended auto-initialization and deep link data loss during the test setup.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

matterai-app · 2026-02-24T03:08:53Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: Similar to the iOS test, this line still uses the old setConsumerProtectionAttributionLevel API which the PR aims to replace to prevent auto-initialization.

Fix: Use the new API with resetSession: false for setting the level to .none to maintain consistency and prevent unintended side effects.

Impact: Prevents unintended auto-initialization and deep link data loss during the test setup.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

matterai-app

🧪 PR Review is completed: The PR introduces the new API to prevent auto-initialization, but still uses the old API in the preceding line, which defeats the purpose of the fix.

matterai-app · 2026-02-24T03:09:04Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: The PR description states that the old setConsumerProtectionAttributionLevel API causes auto-initialization and the fix is to use the new API with the resetSession parameter. However, this line still uses the old API, which might trigger the unwanted auto-initialization before the next line executes.

Fix: Use the new API with resetSession: false for setting the level to .none as well, to ensure auto-initialization is completely avoided.

Impact: Prevents unintended auto-initialization and deep link data loss during the test setup.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

matterai-app · 2026-02-24T03:09:05Z

-
-        let sdk = BranchSDKTest(){  params, error in
-            print(params as? [String: AnyObject] ?? {})
+        Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)


🟡 Logic

Issue: Similar to the iOS test, this line still uses the old setConsumerProtectionAttributionLevel API which the PR aims to replace to prevent auto-initialization.

Fix: Use the new API with resetSession: false for setting the level to .none to maintain consistency and prevent unintended side effects.

Impact: Prevents unintended auto-initialization and deep link data loss during the test setup.

Suggested change

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)

Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

Fixed tests to use new API to disbale auto init.

4f92b8b

NidhiDixit09 requested a review from gdeluna-branch February 24, 2026 02:21

Updated time out.

6b43e73

Test commit

f8092fe

Test commit 2

54c40f7

matterai-app Bot reviewed Feb 24, 2026

View reviewed changes

Test commit 3

7723884

matterai-app Bot reviewed Feb 24, 2026

View reviewed changes

NidhiDixit09 added 2 commits February 23, 2026 19:05

Test commit 4

b6acb5d

Test commit 5

d881673

matterai-app Bot reviewed Feb 24, 2026

View reviewed changes

Test commit 6

f4e6d98

matterai-app Bot reviewed Feb 24, 2026

View reviewed changes

BranchMetrics deleted a comment from johnny1494 Feb 24, 2026

johnny1494 mentioned this pull request Feb 24, 2026

🟡 Logic #1581

Closed

NidhiDixit09 changed the title ~~Fixed tests to use new API to disbale auto init.~~ Fixed tests to use new API to disable auto init. Feb 24, 2026

gdeluna-branch approved these changes Feb 24, 2026

View reviewed changes

NidhiDixit09 merged commit 9b4f654 into 4.0.0-alpha.0 Feb 24, 2026
10 checks passed

	Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none)
	Branch.getInstance().setConsumerProtectionAttributionLevel(BranchAttributionLevel.none, resetSession: false)

Conversation

NidhiDixit09 commented Feb 24, 2026

Reference

Summary

Type Of Change

Testing Instructions

Uh oh!

matterai-app Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary By MatterAI

🔄 What Changed

🔍 Impact of the Change

📁 Total Files Changed

🧪 Test Added/Recommended

Added

Recommended

🔒 Security Vulnerabilities

⏳ Estimated code review effort

Quality Recommendations

♫ Tanka Poem

Sequence Diagram

Uh oh!

matterai-app Bot commented Feb 24, 2026

Uh oh!

matterai-app Bot commented Feb 24, 2026

Uh oh!

matterai-app Bot commented Feb 24, 2026

Uh oh!

matterai-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matterai-app Bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

matterai-app Bot commented Feb 24, 2026 •

edited

Loading