fix: elliptic to noble#194
Open
dargmuesli wants to merge 1 commit intoBrightspace:masterfrom
Open
Conversation
|
Any updates on this? There is another vulnerablity in a dep of elliptic (bn.js) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the elliptic curve cryptography implementation from the deprecated
ellipticlibrary to the more modern and actively maintained@noble/curveslibrary. The changes focus on updating the EC JWK-to-PEM conversion logic to use the new library.Resolves:
Changes:
ellipticdependency with@noble/curvesinpackage.json@noble/curves'sp256,p384, andp521implementations@noble/curvesAPIs for point creation, public key derivation and validation@noble/curves