Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 4/5
- This PR is likely safe to merge, but there is a moderate risk around Docker image publishing if
tag_suffixcontains invalid characters. - In
.github/workflows/build-experimental.yml,tag_suffixis used directly in a Docker tag, so malformed input can break build/push steps. - Pay close attention to
.github/workflows/build-experimental.yml- sanitizetag_suffixbefore composing Docker tags.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/build-experimental.yml">
<violation number="1" location=".github/workflows/build-experimental.yml:31">
P2: Sanitize `tag_suffix` before using it as a Docker tag component; currently invalid input can break image build/push.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
1b931df to
952b431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the problem or feature in addition to a link to the relevant github issues.
Addresses
<Enter the Link to the issue(s) this PR addresses>App Export
Screenshots
If a UI facing feature, a short video of the happy path, and some screenshots of the new functionality.
Launchcontrol
Add a small description in layman's terms of what this PR achieves. This will be used in the release notes.
Summary by cubic
Fixes Ceph S3 compatibility by reading HTTP status codes from AWS SDK v2 and v3 for bucket creation and object existence. Adds an experimental workflow to build and push multi-arch Docker images for testing.
Bug Fixes
objectExists: handle 404 viaerr.$metadata.httpStatusCodeas "not found"; test added for v3 error shape.createBucketIfNotExists: read status fromerr.$metadata.httpStatusCodeand tolerateBucketAlreadyOwnedByYouviaerr.Codeorerr.name.New Features
budibase/appsandbudibase/workerimages tagged asexperimental-<suffix|branch>plus short SHA.Written for commit 063d168. Summary will update on new commits.