Skip to content

Fix/ceph s3 api#18499

Open
calexiou wants to merge 3 commits intomasterfrom
fix/ceph-s3-api
Open

Fix/ceph s3 api#18499
calexiou wants to merge 3 commits intomasterfrom
fix/ceph-s3-api

Conversation

@calexiou
Copy link
Copy Markdown
Contributor

@calexiou calexiou commented Apr 9, 2026

Description

Describe the problem or feature in addition to a link to the relevant github issues.

Addresses

  • <Enter the Link to the issue(s) this PR addresses>
  • ...more if required

App Export

  • If possible, attach an app export file along with your request template to make QA testing easier, with minimal setup.

Screenshots

If a UI facing feature, a short video of the happy path, and some screenshots of the new functionality.

Launchcontrol

Add a small description in layman's terms of what this PR achieves. This will be used in the release notes.


Summary by cubic

Fixes Ceph S3 compatibility by reading HTTP status codes from AWS SDK v2 and v3 for bucket creation and object existence. Adds an experimental workflow to build and push multi-arch Docker images for testing.

  • Bug Fixes

    • objectExists: handle 404 via err.$metadata.httpStatusCode as "not found"; test added for v3 error shape.
    • createBucketIfNotExists: read status from err.$metadata.httpStatusCode and tolerate BucketAlreadyOwnedByYou via err.Code or err.name.
  • New Features

    • Experimental workflow builds and pushes budibase/apps and budibase/worker images tagged as experimental-<suffix|branch> plus short SHA.

Written for commit 063d168. Summary will update on new commits.

@calexiou calexiou self-assigned this Apr 9, 2026
@github-actions github-actions bot added the size/m label Apr 9, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Confidence score: 4/5

  • This PR is likely safe to merge, but there is a moderate risk around Docker image publishing if tag_suffix contains invalid characters.
  • In .github/workflows/build-experimental.yml, tag_suffix is used directly in a Docker tag, so malformed input can break build/push steps.
  • Pay close attention to .github/workflows/build-experimental.yml - sanitize tag_suffix before composing Docker tags.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/build-experimental.yml">

<violation number="1" location=".github/workflows/build-experimental.yml:31">
P2: Sanitize `tag_suffix` before using it as a Docker tag component; currently invalid input can break image build/push.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

@github-actions github-actions bot added size/s and removed size/m labels Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant