fmt/strtime: make strptime with Zoned and only %s work#433
Merged
BurntSushi merged 1 commit intomasterfrom Oct 18, 2025
Merged
Conversation
Previously, if `%s` was parsed and there was no offset (`%z`) or IANA time zone identifier (`%Q`), then trying to pull a `Zoned` out of a `BrokenDownTime` would fail. But arguably, this should work. Namely, the `strptime` APIs are already very relaxed about returning a `Zoned` with fixed offset time zones (where the normal `FromStr` APIs forbid it due to footguns). And since we have a way of representing an unknown time zone, we can do exactly that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if
%swas parsed and there was no offset (%z) or IANAtime zone identifier (
%Q), then trying to pull aZonedout of aBrokenDownTimewould fail. But arguably, this should work. Namely, thestrptimeAPIs are already very relaxed about returning aZonedwithfixed offset time zones (where the normal
FromStrAPIs forbid it dueto footguns). And since we have a way of representing an unknown time
zone, we can do exactly that.