fix XElement copy, added unit tests & vsproject#11
Open
brainbaking wants to merge 1 commit into
Open
Conversation
Owner
|
Interesting, gonna check out XElement source codes, but theoretically any .NET code could be copied by this code. Unless XElement uses unmanaged code, or deal with pointers. |
Author
|
XElement inherits from XContainer and contains an internal object "content" but everything seems to get copied over just fine. Linq expressions like .However, Elements() don't produce the wanted result. I peeked into the Linq source and they simply traverse the content object (as an XNode) so why shouldn't it work indeed? |
Author
|
any news on this? Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for your deep clone utility class! Turns out XElement is not that easily fooled, you have to use their own copy constructor, I fixed that. Also added some unit tests and created a VStudio project for it.
If you'd like, you can join this commit onto your master branch.
Thanks again,
-- Wouter.