Merge colorpicker changes into release#1257
Conversation
Colorpicker now uses manager correctly
Fixes typo in CDMS raise statements
|
@aashish24 This merges my PR and Remi's into release |
Merge colorpicker changes into release
|
? no reviews? |
|
I just merged over from master; it was code that was already reviewed, and both Remi and I had aimed at the wrong branch. From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com> ? no reviews? — |
|
that said, we can back out the changes. I just figured it wasn't a big deal. |
|
no problem. okay, but create a new branch, so that the we have a proper name of the branch. |
|
😕 You want me to do what exactly? |
|
On the top it says: which means that you are directly merging from master into release. Intstead you would do:
and then will do a pull request on that. In that way we know (without github interface) what change you bought in in git log or gitk --first-parent |
|
ah, gotcha. |
|
Will do! |
|
thanks 👍 |
No description provided.