Skip to content

we used to have two path for rendering a frame #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doutriaux1 merged 3 commits into from
Jun 22, 2016
Merged

we used to have two path for rendering a frame #2028

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
567bffd
we used to have two path for rendering a frame
doutriaux1 Jun 14, 2016
24922f7
making @chaoshpere2112 happy, generating pngs only for save or zoomed…
doutriaux1 Jun 15, 2016
08fbba2
Merge branch 'master' into issue_1845_animation_cmap_not_preserved
doutriaux1 Jun 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Packages/vcs/vcs/VTKAnimate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,8 @@ def reclaim_renderers(self):
be.showGUI()
be.renWin.Render()

def draw_frame(self, frame_num=None, render_offscreen=True,
allow_static=True, main_window_png=False):
def draw_frame(self, frame_num=None, render_offscreen=False,
allow_static=False, main_window_png=True):
"""
Draws a frame on the canvas
frame_num: Which frame to draw- defaults to self.frame_num
Expand All @@ -295,8 +295,7 @@ def draw_frame(self, frame_num=None, render_offscreen=True,
else:
self.frame_num = frame_num

if render_offscreen or (
allow_static and len(self.animation_files) == self.number_of_frames()):
if len(self.animation_files) == self.number_of_frames():
# Attempt to extract the renderers and place them onto the create
# thread
self.extract_renderers()
Expand All @@ -318,7 +317,7 @@ def draw_frame(self, frame_num=None, render_offscreen=True,

self.vcs_self.backend.renWin.Render()

if main_window_png:
if main_window_png or self.playback_params.zoom_factor != 1:
png_name = self.create_thread.get_frame_name(self.frame_num)
self.vcs_self.png(png_name)
self.animation_files = sorted(
Expand Down Expand Up @@ -346,4 +345,5 @@ def frame(self, frame):
self.draw_frame(
frame_num=frame,
allow_static=False,
render_offscreen=False)
render_offscreen=False,
main_window_png=False)
⚡