Skip to content

need to pass -b to build cdat_info out of source#2051

Merged
doutriaux1 merged 5 commits intomasterfrom
issue_2047_cdat_info
Aug 10, 2016
Merged

need to pass -b to build cdat_info out of source#2051
doutriaux1 merged 5 commits intomasterfrom
issue_2047_cdat_info

Conversation

@doutriaux1
Copy link
Copy Markdown
Contributor

@danlipsa @chaosphere2112 please review.

@danlipsa you can inspire yourself (and improve) to do al the out of source building

@danlipsa
Copy link
Copy Markdown
Contributor

danlipsa commented Jul 8, 2016

@doutriaux1 I don't see the text version of cdat_info.py.in deleted from build.sh

@doutriaux1
Copy link
Copy Markdown
Contributor Author

@danlipsa I forgot to push it the first time it should be in now

@danlipsa
Copy link
Copy Markdown
Contributor

@doutriaux1 I still cannot see the deleted python source in the commit.

@doutriaux1
Copy link
Copy Markdown
Contributor Author

@danlipsa what is the issue here?

@danlipsa
Copy link
Copy Markdown
Contributor

@doutriaux1 The source for cdat_info.py.in was originally included in build.sh and should be deleted from there, isn't it?

@kwrobot
Copy link
Copy Markdown
Member

kwrobot commented Jul 26, 2016

Basic content checks failed!

commit be118579 adds
  Packages/cdat_info/setup.py
without executable mode, but the file looks executable

Branch-at: be11857
Rejected-by: @kwrobot

@doutriaux1
Copy link
Copy Markdown
Contributor Author

@danlipsa yes once we merged that in I will need to update the conda_recipes repo to yank from there.

@danlipsa
Copy link
Copy Markdown
Contributor

@doutriaux1 I see. I was looking for that in here. LGTM 👍

@kwrobot
Copy link
Copy Markdown
Member

kwrobot commented Jul 26, 2016

Basic content checks failed!

commit 28522e96 has committer name "GitHub" with no space.  Run
  git config --global user.name 'Your Name'
  git config --global user.email 'you@yourdomain.com'
before creating commits.
commit be118579 adds
  Packages/cdat_info/setup.py
without executable mode, but the file looks executable

Changes since last check: compare

Branch-at: 28522e9
Rejected-by: @kwrobot

@doutriaux1 doutriaux1 merged commit 56af19b into master Aug 10, 2016
@doutriaux1 doutriaux1 deleted the issue_2047_cdat_info branch August 10, 2016 21:12
chaosphere2112 pushed a commit that referenced this pull request Sep 1, 2016
* need to pass -b to build cdat_info out of source

* Added cdat_info to list of pkg to build

* works better with files...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants