need to pass -b to build cdat_info out of source#2051
Merged
doutriaux1 merged 5 commits intomasterfrom Aug 10, 2016
Merged
Conversation
Contributor
|
@doutriaux1 I don't see the text version of cdat_info.py.in deleted from build.sh |
Contributor
Author
|
@danlipsa I forgot to push it the first time it should be in now |
Contributor
|
@doutriaux1 I still cannot see the deleted python source in the commit. |
Contributor
Author
|
@danlipsa what is the issue here? |
Contributor
|
@doutriaux1 The source for cdat_info.py.in was originally included in build.sh and should be deleted from there, isn't it? |
Member
Contributor
Author
|
@danlipsa yes once we merged that in I will need to update the conda_recipes repo to yank from there. |
Contributor
|
@doutriaux1 I see. I was looking for that in here. LGTM 👍 |
Member
|
Basic content checks failed! Changes since last check: compare |
chaosphere2112
pushed a commit
that referenced
this pull request
Sep 1, 2016
* need to pass -b to build cdat_info out of source * Added cdat_info to list of pkg to build * works better with files...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@danlipsa @chaosphere2112 please review.
@danlipsa you can inspire yourself (and improve) to do al the out of source building