Merged
Conversation
aashish24
force-pushed
the
fix_export_svg
branch
from
c1303ee to
8991302
Compare
Contributor
Author
Contributor
Author
|
@sankhesh @doutriaux1 please review. |
Contributor
|
Awesome! thanks @aashish24 will take a look as soon as possible! |
Contributor
Author
|
Do: test |
Contributor
|
LGTM 👍 |
Contributor
|
@aashish24 @sankhesh I'm about to test this, but I doubt it's going to change anything since my test was a regular isofill no hatch or pattern. |
Contributor
|
@aashish24 @sankhesh ok I just produced an ungroupable svg on my mac with this branch. I'm going to try it on a Linux system and see if it fixes the svgs for metadiags. Thanks |
Contributor
|
@aashish24 @sankhesh with that branch I can ungroup svgs for both boxfill and isofill but not with master. I'm not really sure what's the diff... But hey I'm so happy! |
Contributor
Author
|
great! thanks for the update @doutriaux1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.