Issue 628 regridder regird2 mthod gens nan#860
Merged
alliepiper merged 3 commits intomasterfrom Oct 31, 2014
Merged
Conversation
Member
|
@doutriaux1 it would be great to pull some of my test data into a test case for this specifically.. |
Member
|
This issue should resolve #628, PCMDI/pcmdi_metrics#68 |
alliepiper
pushed a commit
that referenced
this pull request
Oct 31, 2014
…d_gens_nan Issue 628 regridder regird2 mthod gens nan
Contributor
|
lgtm |
This was referenced Oct 31, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@williams13 @aashish24 @dlonie @ThomasMaxwell this actually fixes a nasty bug due to the new numpy (missing value is defaulted to nan) that led to erroneous result for regrid2 (at least) @durack1 as been testing this for a few days and while he confirms this fixes his issue with the regridder he didn't see any nasty side effects.
I think this should be merged as soon as possible.