Skip to content

Additional test for BUG #5: vtkPolyData::RemoveDeletedCells does not …#2124

Merged
doutriaux1 merged 5 commits intomasterfrom
fix_isofill_levels
Sep 30, 2016
Merged

Additional test for BUG #5: vtkPolyData::RemoveDeletedCells does not …#2124
doutriaux1 merged 5 commits intomasterfrom
fix_isofill_levels

Conversation

@danlipsa
Copy link
Copy Markdown
Contributor

@danlipsa danlipsa commented Sep 26, 2016

…remove GlobalIds or points.

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Sep 26, 2016

@doutriaux1 @aashish24 This is an additional test for the vcs isofill fix. Please review.

@danlipsa danlipsa mentioned this pull request Sep 26, 2016
Merged
@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Sep 26, 2016

Do: test

@cdatrobot
Copy link
Copy Markdown

cdatrobot commented Sep 26, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: a75203f

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Sep 26, 2016

@doutriaux1 I should add the previous tests from datawc commit as well isn't it?

@doutriaux1
Copy link
Copy Markdown
Contributor

doutriaux1 commented Sep 26, 2016

I think so

doutriaux1 and others added 4 commits September 26, 2016 15:36
@doutriaux1 @dnadeau4
Split repos (#2123)
a4aaea3 
* don't go to directory, clone repo instead

* 3 repos splitted: cdtime, cdms2, regrid2

* cdutil split

* genutil splitted

* cmor gone a long time ago

* beyhond obsolete package

* visus is deprecated

* split wk

* Thermo migrated

* moved distarray xmgrace psql vcsaddons unidata

* moved a bunch of package to a 'Dead' directory

* removed vcs repo

* clone from build directory

* removed DV3D

* removed mac from test on travis, it always hangs

* testing is being moved to vcs

* checking out the same branch on all repo as the current branch

* trying ot use testing from vcs rather than package

* more testing to vcs regression changes

* clean local
@dnadeau4 @doutriaux1
Fix test suite vcs imports (#2126)
0975051 
* Add numpy1_11 fixes

* Add numpy1_11 for cdat_module_extra

* add cmor

* force channell nadeau1/label/1234 for testing

* wrong channel

* add some echo commands

* fix test suite vcs import
@doutriaux1
tweaks test to pass with split_repos and moved tsting pakg
6df3608
@doutriaux1
Merge remote-tracking branch 'origin/fix_isofill_levels' into fix_iso…
24f85dc 
…fill_levels
@doutriaux1
Copy link
Copy Markdown
Contributor

doutriaux1 commented Sep 28, 2016

@danlipsa almost all good, but in diags the vectors disappeared, see:
https://open.cdash.org/testDetails.php?test=487168860&build=4573138

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Sep 28, 2016

@doutriaux1 I'll take a look.

@doutriaux1
Copy link
Copy Markdown
Contributor

doutriaux1 commented Sep 29, 2016

@danlipsa any progress on this? I would like to merge it in soon

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Sep 29, 2016

@doutriaux1 I should be able to push a fix soon. The problem is similar with what I fixed before but slightly trickier - I cannot set the hidden vectors to a value because they'll still show up. I try to just delete the points.

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Sep 29, 2016

@doutriaux1 Feel free to apply your commits to the master branch. This way you won't depend on my PR. Your commits and my PR should be independent.

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Sep 30, 2016

@doutriaux1 @aashish24 An update on this. Here is a picture that shows the hidden points in red. I remove the cells around the hidden points, but note that there are some points left in the hidden area.
hidden-points
This causes some additional arrows. Those did not show up in the past, I think because of the default hidden point behavior which I think deletes the cells around a hidden point and also deletes all cell points.
Here are the two pictures: test result:
figure-set6_global_ann_stress_plot-combined
baseline:
figure-set6_global_ann_stress_plot-combined
I can restore the old behavior but I wanted to point this out.

@doutriaux1
Copy link
Copy Markdown
Contributor

doutriaux1 commented Sep 30, 2016

@danlipsa I think this is fine, but can you push this so that we see the new baselines differences on cdash? It's easier with the slider.

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Sep 30, 2016 •
edited
Loading

@doutriaux1 @aashish24 I pushed the fix. All tests pass in dignostics - probably the difference I pointed out is too small. A new baseline was changed in uvcdat.

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Sep 30, 2016

For your reference, these are the additional PRs:
CDAT/uvcdat-testdata#155
CDAT/vcs#10

@doutriaux1 doutriaux1 merged commit 9be9c7f into master Sep 30, 2016
@doutriaux1 doutriaux1 deleted the fix_isofill_levels branch September 30, 2016 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danlipsa @cdatrobot @doutriaux1 @dnadeau4
⚡