Skip to content

Fix isofill levels#10

Merged
doutriaux1 merged 4 commits intomasterfrom
fix_isofill_levels
Sep 30, 2016
Merged

Fix isofill levels#10
doutriaux1 merged 4 commits intomasterfrom
fix_isofill_levels

Conversation

@danlipsa
Copy link
Copy Markdown
Contributor

No description provided.

@danlipsa
Copy link
Copy Markdown
Contributor Author

@doutriaux1 @aashish24 Please review. Where do I commit the new png and nc for the new testfile as well as changes to uvcdat/CMakeLists.txt?

@doutriaux1
Copy link
Copy Markdown
Contributor

thanks @danlipsa please commit to the usual repo for baselines UV-CDAT/uvcdat-testdata and createa branch with this branch's name on the UVCDAT/uvcdat repo, that should trigger the test suite.

@danlipsa
Copy link
Copy Markdown
Contributor Author

@doutriaux1 Thanks.
Here are the additional PR:
CDAT/uvcdat-testdata#155
CDAT/cdat#2124

@danlipsa
Copy link
Copy Markdown
Contributor Author

@doutriaux1 @aashish24 The fix is the second commit. The first commit is identical to the one reversed.

@aashish24
Copy link
Copy Markdown
Contributor

@danlipsa in theory the code looks good to me. Basically you are setting some valid value to hidden points so that scalar range does not change. @doutriaux1 can you confirm if this fixes the issue for you?

@danlipsa
Copy link
Copy Markdown
Contributor Author

@aashish24 That is right. I also remove the globalid attribute and then add it back because otherwise RemoveDeletedCells does not remove the globalid associated with the deleted cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants