Merged
Conversation
scottwittenburg
approved these changes
May 1, 2019
Collaborator
scottwittenburg
left a comment
scottwittenburg
left a comment
There was a problem hiding this comment.
Question: This environment.yml was only used to generate the online documentation?
Otherwise: Looks good to me.
…if linux py3 passes, this saves credits when flake8 fails for example
Contributor
Author
|
@scottwittenburg yes only by readthe doc. Maybe i will rename it just to be safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@scottwittenburg @danlipsa @jypeter this finally fixes readthedocs
see: https://cdat-vcs.readthedocs.io/en/rtd_again/
The issue was that conda was taking too much memory (more than 1Gb!) to solve the full vcs dependencies.
In theory you shouldn't need
vtkto import vcs anyway since one could choose another backend (I know there's only one) so the vtk dependency should come later. This is the first step toward true backend independence.It is important since currently the docs are just incomplete for vcs on readthedocs.