Merged
Conversation
Contributor
jasonb5
commented
Jun 3, 2020
jasonb5
commented
- Updates makefile to continue using CDAT/conda-recipes for rerender/building similar to conda-forge process.
- Updates circleci config to use makefile.
- Stores package and spec list during build process, assist in reproduce failed environments.
…se to use labeled packages. run make_doc_tests
…een merged, and try rerunning with libnetcdf mpi_mpich variant
muryanto1
approved these changes
Jul 4, 2020
Member
muryanto1
left a comment
muryanto1
left a comment
There was a problem hiding this comment.
we will need to revisit running tests with coverage.
| cd uvcdat-testdata; git pull | ||
| endif | ||
|
|
||
| run-tests: |
Member
There was a problem hiding this comment.
is it possible for 'make run-tests' to return the value returned my "python run_tests.py..."? In circleci, when I run the workflow, if any test failed, I want to exit the circleci workflow.
In nightly test runs though (another circleci workflow), I ran test suites of all projects, if any test suite fail, I want to keep on running the project's test suite. I.e. in this case I will just ignore the exit value of 'make run-tests'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.