Update Icepack, update documentation, minor bibtex and gptl updates#1015
Merged
apcraig merged 4 commits intoCICE-Consortium:mainfrom Apr 9, 2025
Merged
Update Icepack, update documentation, minor bibtex and gptl updates#1015apcraig merged 4 commits intoCICE-Consortium:mainfrom
apcraig merged 4 commits intoCICE-Consortium:mainfrom
Conversation
- Update derecho gnu and code coverage capability - Update Copyright - Fix bug with calc_Tsfc=F, set_sfcflux arguments reversed in icepack_therm_vertical.F90 - Fix negative silicate bgc bug - Update of Mosaic forcing option Comment out gptl pid check in ice_memusage_gptl.c. The check is not needed, and the arbitrary value of 999999 occasionally fails because on many systems the upper limit is higher. This has not come up in CICE, but it has been noted in other models' use of gptl, https://cerfacs.fr/site-oasis/forum/oa_main.php?c=177. Update documentation regarding history variable units and cona and conb history variable conversion terms.
with the latest version.
eclare108213
approved these changes
Apr 9, 2025
Contributor
eclare108213
left a comment
eclare108213
left a comment
There was a problem hiding this comment.
One small correction in the docs, otherwise looks great. Thanks -
| "coldice", "value for constant albedo parameterization", "0.70" | ||
| "coldsnow", "value for constant albedo parameterization", "0.81" | ||
| "cona", "history units converion variable, multiplication term", "1.0" | ||
| "conb", "history units converion variable, additive term", "0.0" |
Contributor
There was a problem hiding this comment.
correct spelling of conversion, both lines
Contributor
Author
There was a problem hiding this comment.
good catch, I corrected it.
dabail10
reviewed
Apr 9, 2025
Contributor
There was a problem hiding this comment.
Why are there all these changes to the source code?
Contributor
There was a problem hiding this comment.
This PR updates CICE with the newest Icepack, with all its changes.
Contributor
There was a problem hiding this comment.
Oh, I missed the icepack PR.
dabail10
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Update Icepack, update documentation, minor bibtex and gptl updates
apcraig
Bit-for-bit on derecho full test suite except BGC cases due to Icepack silicate fix (expected), https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#0355cef27d6d8765b711a2e0a5974eff83fdedf1
Update Icepack to #51695d08d92c20 April 4, 2025. Includes
- Update derecho gnu and code coverage capability
- Update Copyright
- Fix bug with calc_Tsfc=F, set_sfcflux arguments reversed in icepack_therm_vertical.F90
- Fix negative silicate bgc bug
- Update of Mosaic forcing option
Comment out gptl pid check in ice_memusage_gptl.c. The check is not needed, and the arbitrary value of 999999 occasionally fails because on many systems the upper limit is higher. This has not come up in CICE, but it has been noted in other models' use of gptl, https://cerfacs.fr/site-oasis/forum/oa_main.php?c=177.
Update documentation regarding history variable units and cona and conb history variable conversion terms.
Update sphinx-bibtex version in doc requirements. Readthedocs now works with the latest version.
Closes #546
Closes #1014