feat(api): add public volunteers to _data to support displaying volunteer credits on the website#516
Merged
kevee merged 5 commits intoCOVID19Tracking:masterfrom Apr 17, 2020
muamichali:volunteer-credits
Merged
feat(api): add public volunteers to _data to support displaying volunteer credits on the website#516kevee merged 5 commits intoCOVID19Tracking:masterfrom muamichali:volunteer-credits
kevee merged 5 commits intoCOVID19Tracking:masterfrom
muamichali:volunteer-credits
Conversation
muamichali
changed the title
muamichali
changed the title
muamichali
changed the title
kevee
requested changes
Apr 17, 2020
Contributor
kevee
left a comment
kevee
left a comment
There was a problem hiding this comment.
I think you need to run npm i --save @slack/web-api and commit the changes to package and package-lock. The last build failed because the package was missing.
|
Deploy preview for upbeat-lovelace-3e9fff ready! Built with commit 23d6c82 https://deploy-preview-516--upbeat-lovelace-3e9fff.netlify.app |
kevee
approved these changes
Apr 17, 2020
Contributor
kevee
left a comment
kevee
left a comment
There was a problem hiding this comment.
This is great work, @muamichali! I'm announcing the profile fields in Slack right now and will merge this in this afternoon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting work on #496