Skip to content

Add document repository#947

Merged
kevee merged 6 commits intomasterfrom
schwartzadev/document-repository
Jun 1, 2020
Merged

Add document repository#947
kevee merged 6 commits intomasterfrom
schwartzadev/document-repository

Conversation

@schwartzadev
Copy link
Copy Markdown
Contributor

Description

Adds pages at /documents/<slug> for documents pulled from Contentful. Closes #934

@schwartzadev schwartzadev requested a review from kevee May 29, 2020 02:38
@netlify
Copy link
Copy Markdown

netlify bot commented May 29, 2020

This is a preview version of the site.

Built with commit 37a4b69

https://deploy-preview-947--upbeat-lovelace-3e9fff.netlify.app

@calibre-analytics
Copy link
Copy Markdown

calibre-analytics bot commented May 29, 2020

Comparing Add document repository Snapshot #5 to median since last deploy of The COVID Tracking Project.

Performance FCP? TTI?
Overall
Median across all pages and test profiles
70
from 92
1.1s
from 670ms
3.3s
from 3.8s
Chrome Desktop
Chrome • Cable
81
from 100
810ms
from 420ms
2.4s
from 1.7s
MotoG4, 3G connection
Motorola Moto G4 • Regular 3G
63
from 86
1.3s
from 1.1s
4.4s
from 5.3s

2 pages tested

 Home

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
Chrome Desktop
144 Bytes
from 94 KB
Total JSON size in bytes
MotoG4, 3G connection
144 Bytes
from 130 KB
Lighthouse Performance Score
MotoG4, 3G connection
71
from 86
Total Page size in bytes
Chrome Desktop
1.2 MB
from 1.5 MB
Total Page size in bytes
MotoG4, 3G connection
1.3 MB
from 1.5 MB

2 other significant changes: Total JavaScript size in bytes on Chrome Desktop, Total JavaScript size in bytes on MotoG4, 3G connection

 Data page

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
First Contentful Paint
Chrome Desktop
990ms
from 440ms
First Meaningful Paint
Chrome Desktop
990ms
from 440ms
Largest Contentful Paint
Chrome Desktop
990ms
from 440ms
Speed Index
Chrome Desktop
980ms
from 440ms
Total JSON size in bytes
Chrome Desktop
50 KB
from 100 KB

5 other significant changes: Lighthouse Performance Score on MotoG4, 3G connection, Total JSON size in bytes on MotoG4, 3G connection, Lighthouse Performance Score on Chrome Desktop, Total JavaScript size in bytes on Chrome Desktop, Total JavaScript size in bytes on MotoG4, 3G connection

Calibre: Site dashboard | View this PR | Edit settings

@kevee
Copy link
Copy Markdown
Contributor

kevee commented May 29, 2020

@schwartzadev - looking good! New feature request:

Can we also add Netlify redirects to make clean URLs for the documents?

  • Add slug and the file URL to the fetched fields in the query in gatsby-node
  • use createRedirect to make a redirect from /document/download/[slug] to the URL in Contentful
  • change the download link in the document page to link to that redirect

Copy link
Copy Markdown
Contributor

@kevee kevee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @schwartzadev! Merging

@kevee kevee merged commit b19da00 into master Jun 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the schwartzadev/document-repository branch June 1, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document repository

2 participants