Update cardano-node dependencies#203
Open
SupernaviX wants to merge 2 commits into
Open
Conversation
SupernaviX
commented
May 7, 2026
| type Point = Ouroboros.Point Block | ||
|
|
||
| instance ToJSON Point where | ||
| instance {-# OVERLAPPING #-} ToJSON Point where |
Author
There was a problem hiding this comment.
I'm not sure whether or not this is safe; Point got a ToJSON encoding which is incompatible with this one, and I'm not sure where (if anywhere) that gets used in the libraries.
Member
There was a problem hiding this comment.
The instance is likely used only for tracing; to be double checked but this should be okay
SupernaviX
commented
May 7, 2026
| bytes <- decodeBase16' hexText | ||
|
|
||
| tx <- case decodeCborAnn @ConwayEra "PartialTransaction" decCBOR (fromStrict bytes) of | ||
| tx <- case decodeCborAnn @BabbageEra "PartialTransaction" (decCBOR @(Annotator (Ledger.Tx TopTx BabbageEra))) (fromStrict bytes) of |
Author
There was a problem hiding this comment.
I'm not very confident about changing this to expect Babbage, but
- Typechecking failed when trying to use ConwayEra
- This function is using a lot of what look like babbage-specific helpers on
tx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to cardano-node 11.0.1 and associated libraries.
Fixes #202 (Kupo starts up when run against a new node), but does not actually add Dijkstra support (that seems to be a significant breaking change)