Skip to content

Nest connection inside getServerHealth options paramater #135

@rhyslbw

Description

@rhyslbw

After #134 is merged there will be two optional parameters in the getServerHealth function. To align with the pattern of defining a single options argument, we would need to introduce a breaking change.

export const getServerHealth = async (
connection?: Connection
): Promise<ServerHealth> => {

export const getServerHealth = async ( 
  options? {
    connection?: Connection,
    logger?: Logger
  } 
 ): Promise<ServerHealth> => { 

Metadata

Metadata

Assignees

No one assigned

    Labels

    client/TypeScriptIssues which regard the TypeScript client

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions