This repository was archived by the owner on Apr 14, 2026. It is now read-only.
[ENG-7472] fixed recent preprint rejected versions doesnt have option to resubmit#2528
Merged
brianjgeiger merged 3 commits intoCenterForOpenScience:feature/pbs-25-05from Mar 21, 2025
Conversation
brianjgeiger
suggested changes
Mar 19, 2025
Contributor
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
Just a couple of incorrect messages in the test assertions.
| }); | ||
| await settled(); | ||
| assert.dom('[data-test-edit-preprint-button]') | ||
| .exists('Edit button is not displayed for non-initial pre-mod latest rejected'); |
Contributor
There was a problem hiding this comment.
I don't think this message is correct. Isn't the edit button displayed here?
| await settled(); | ||
| assert.dom('[data-test-edit-preprint-button]') | ||
| .doesNotExist('Edit button is not displayed for non-initial pre-mod rejected'); | ||
| .exists('Edit button is not displayed for non-initial pre-mod not latest rejected'); |
Contributor
There was a problem hiding this comment.
I don't think this message is correct. Isn't the edit button displayed here?
futa-ikeda
approved these changes
Mar 20, 2025
brianjgeiger
approved these changes
Mar 21, 2025
brianjgeiger
merged commit 62a0709
into
CenterForOpenScience:feature/pbs-25-05
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make it possible to resubmit rejected preprint versions
Summary of Changes
Make it possible to resubmit rejected preprint versions
Screenshot(s)
Side Effects
TBD
QA Notes
TBD