Skip to content

[ENG-10910] Prevent updating invalid social attr when confirming ORCID#11717

Merged
adlius merged 1 commit intoCenterForOpenScience:hotfix/26.8.1from
futa-ikeda:hotfix/orcid-email-confirm
Apr 28, 2026
Merged

[ENG-10910] Prevent updating invalid social attr when confirming ORCID#11717
adlius merged 1 commit intoCenterForOpenScience:hotfix/26.8.1from
futa-ikeda:hotfix/orcid-email-confirm

Conversation

@futa-ikeda
Copy link
Copy Markdown
Contributor

@futa-ikeda futa-ikeda commented Apr 28, 2026

Ticket

Purpose

  • Fix test failures caused by existing code updating social.orcid that is no longer valid h/t @aaxelb

Changes

Side Effects

QE Notes

CE Notes

Documentation

@futa-ikeda futa-ikeda changed the title Prevent updating invalid social attr when confirming ORCID [ENG-10910] Prevent updating invalid social attr when confirming ORCID Apr 28, 2026
Copy link
Copy Markdown
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good ⭐

Note: I am not sure why this didn't fail every time. In fact, it rarely fails. It never failed for me in my PRs (which has latest develop and it never failed when I tested it a few times locally.

@adlius adlius merged commit 82ae1b6 into CenterForOpenScience:hotfix/26.8.1 Apr 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants