[ENG-10910] Prevent updating invalid social attr when confirming ORCID#11717
Merged
adlius merged 1 commit intoCenterForOpenScience:hotfix/26.8.1from Apr 28, 2026
Merged
Conversation
brianjgeiger
approved these changes
Apr 28, 2026
cslzchen
approved these changes
Apr 28, 2026
Collaborator
cslzchen
left a comment
There was a problem hiding this comment.
Fix looks good ⭐
Note: I am not sure why this didn't fail every time. In fact, it rarely fails. It never failed for me in my PRs (which has latest develop and it never failed when I tested it a few times locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
social.orcidthat is no longer valid h/t @aaxelbChanges
Side Effects
QE Notes
CE Notes
Documentation