Add annotations field to hardcoded copy of record ontology in frontend#352
Merged
jgonggrijp merged 1 commit intodevelopfrom Apr 27, 2026
Merged
Add annotations field to hardcoded copy of record ontology in frontend#352jgonggrijp merged 1 commit intodevelopfrom
jgonggrijp merged 1 commit intodevelopfrom
Conversation
This is a temporary solution while we figure out #351.
tijmenbaarda
approved these changes
Apr 26, 2026
Contributor
tijmenbaarda
left a comment
tijmenbaarda
left a comment
There was a problem hiding this comment.
I am sorry for the late review! Yes, this works, and together with #353 this should be enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel to CentreForDigitalHumanities/edpop-record-ontology#10, I have copy-pasted the JSON-LD description of the new field to the hardcoded copy of the record ontology in the VRE frontend. This seemed the fastest way to ensure that Jeroen could start adding annotations, rather than going out of my way to fully address #351 first.
The only code change is a JSON-LD duplicate of CentreForDigitalHumanities/edpop-record-ontology#10, so this is probably not interesting to review. However, please do think along with me: is this really enough to ensure that Jeroen can annotate? I think it is but I might be mistaken!