chore: update peer-id

[achingbrain]

Pulls in the new peer-id

Needs a new release of @chainsafe/libp2p-noise though it's just a dev dep so this could go out without it.

BREAKING CHANGE: requires node 15+

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.58%. Comparing base (751ea73) to head (42d8546).
⚠️ Report is 297 commits behind head on master.

Files with missing lines	Patch %	Lines
test/utils/index.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   76.58%   76.58%           
=======================================
  Files           2        2           
  Lines        1905     1905           
  Branches      144      144           
=======================================
  Hits         1459     1459           
  Misses        446      446           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dapplion]

@achingbrain what breaks with Node < v16?

[achingbrain]

Node only used to be able to give us keypairs in pem format, which we'd then use pem-jwk to transform to jwk - starting with node 15 it can give us the keys in jwk directly so we don't need the extra dep any more.

https://github.com/libp2p/js-libp2p-crypto/blob/master/src/keys/rsa.js#L14-L15

[achingbrain]

Same with signing/verifying using RSA, we used to have to transform the key format before hand, now we can just pass it to node crypto directly.

[dapplion]

Node only used to be able to give us keypairs in pem format, which we'd then use pem-jwk to transform to jwk - starting with node 15 it can give us the keys in jwk directly so we don't need the extra dep any more.

https://github.com/libp2p/js-libp2p-crypto/blob/master/src/keys/rsa.js#L14-L15

Is it feasible to have a fallback for Node v14? I haven't though in depth our node version support strategy but if the cost is low it's a good to have.

[achingbrain]

It means adding the pem-jwk dep back in and not using the features from node 15. Node 16 is Active LTS now though, so that's the minimum version we support, officially.

[dapplion]

It means adding the pem-jwk dep back in and not using the features from node 15. Node 16 is Active LTS now though, so that's the minimum version we support, officially.

Agree with your policy, let's stick to v16 then

[achingbrain]

Phew, CI passing. I think long term all the delay(...)s need to be removed from the tests, some of the values are too aggressive for resource constrained environments like GH actions.

[vasco-santos]

awesome

[vasco-santos]

LGTM