chore: make libp2p-crypto a dev dep#115
Merged
dapplion merged 1 commit intoChainSafe:masterfrom Dec 1, 2021
Merged
Conversation
Contributor
|
Makes sense! Agree with the change. However should we keep both the package-lock.json and yarn.lock? |
Collaborator
Author
Ha! Oops. I've removed the newly added |
It's only used to verify incoming message payloads but the `pubKey` property on `PeerId` can do that.
8c59466 to
a48294c
Compare
dapplion
approved these changes
Nov 30, 2021
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 89.13% 89.13% -0.01%
==========================================
Files 16 16
Lines 1832 1831 -1
Branches 243 243
==========================================
- Hits 1633 1632 -1
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's only used to verify incoming message payloads but the
pubKeyproperty onPeerIdcan do that.