Skip to content

chore: make libp2p-crypto a dev dep#115

Merged
dapplion merged 1 commit intoChainSafe:masterfrom
achingbrain:chore/make-libp2p-crypto-a-dev-dep
Dec 1, 2021
Merged

chore: make libp2p-crypto a dev dep#115
dapplion merged 1 commit intoChainSafe:masterfrom
achingbrain:chore/make-libp2p-crypto-a-dev-dep

Conversation

@achingbrain
Copy link
Copy Markdown
Collaborator

It's only used to verify incoming message payloads but the pubKey property on PeerId can do that.

@dapplion
Copy link
Copy Markdown
Contributor

Makes sense! Agree with the change. However should we keep both the package-lock.json and yarn.lock?

@achingbrain
Copy link
Copy Markdown
Collaborator Author

should we keep both the package-lock.json and yarn.lock?

Ha! Oops. I've removed the newly added package-lock.json file.

It's only used to verify incoming message payloads but the `pubKey`
property on `PeerId` can do that.
@achingbrain achingbrain force-pushed the chore/make-libp2p-crypto-a-dev-dep branch from 8c59466 to a48294c Compare November 30, 2021 11:25
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 30, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.13%. Comparing base (735f287) to head (a48294c).
⚠️ Report is 217 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   89.13%   89.13%   -0.01%     
==========================================
  Files          16       16              
  Lines        1832     1831       -1     
  Branches      243      243              
==========================================
- Hits         1633     1632       -1     
  Misses        199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dapplion dapplion merged commit 07a6cd6 into ChainSafe:master Dec 1, 2021
@achingbrain achingbrain deleted the chore/make-libp2p-crypto-a-dev-dep branch December 1, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants